1304456 - Create a wrapper around WKWebView

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect, P1)

Description

[Brian Nicholson (:bnicholson)]

For our efforts to support content blocking, my plan is to do a fine-grained wrapping on top of all of our existing WK* API calls, keeping the shim as close to these APIs as possible. From there, we can port UIWebView to this same API. If everything goes well, that means our actual codebase can essentially remain unchanged.

This bug is for the first step: creating the shim layer.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2127

Here's a shim that wraps WKWebView that, in theory, will allow us to swap in UIWebView if we implement the same set of APIs. There's probably no point in landing this until we know if/when the UIWebView implementation is ready since this doesn't do anything on its own, but I'm posting this PR in case anyone wants to take a look now.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8794994 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2127

We're definitely interested in moving forward with this work, so might as well get some eyes on this.

Here's a branch that basically just wraps WKWebView in a shim. There a few tricky implementation details to get this to work properly, but the end result should be that the shimmed browser works exactly as it does on master.

A few options for merging:
1) We can merge this into master, which shouldn't have any major implications so long as the shim is implemented correctly. Might be useful to get this to a bigger audience to help hunt down those bugs.
2) Keep this maintained in a separate branch, where we can make separate builds for people that want to test these experiments. We can merge to master later once we're sure we want it in the product.

Comment 3

[Brian Nicholson (:bnicholson)]

Landed in branch uiwebview: 9d83c1f91dd5fb296280406b150c3cc7f0a5e10b