1304611 - Child review requests are erroneously displaying the reopen UI

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[:glob ✱]

(Mark Côté [:mcote] from Bug 1163095 comment #4)
> Note that something has regressed and people are able to close commit review
> requests (and are regularly doing so).

we can either fix the regression and only show the UI for closing commit review requests on the parent, or make it so closing/etc any child updates the status of all commits (ie. parent and all children).

Comment 1

[:glob ✱]

Attachment: mozreview: Prevent direct reopening of child requests (bug 1304611)

Review commit: https://reviewboard.mozilla.org/r/80346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80346/

Comment 2

[:glob ✱]

Attachment: mozreview: Add parentID to the MozReview object (bug 1304611);

Review commit: https://reviewboard.mozilla.org/r/80348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80348/

Comment 3

[:glob ✱]

Attachment: mozreview: Add a link to the parent on submitted children (bug 1304611)

Make it easier for people to reopen submitted requests by adding a link to the
parent on submitted children.

Review commit: https://reviewboard.mozilla.org/r/80350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80350/

Comment 5

[Mark Côté [:mcote]]

From bug 1305751:

> Could the push command prompt the user to re-open the necessary reviews as well? That is, similarly to how it prompts you to
> publish the review or not.

I'm not sure if this is fixed here or not.  If so, then please dupe bug 1300506 over here as well.

Comment 6

[Steven MacLeod [:smacleod]]

Comment on attachment 8793630 [details]
mozreview: Prevent direct reopening of child requests (bug 1304611)

https://reviewboard.mozilla.org/r/80346/#review83076

This'll work as a band-aid until we hook up the proper reopen from any request. I just wonder where we lost the CSS that did this before...

Comment 7

[Steven MacLeod [:smacleod]]

Comment on attachment 8793631 [details]
mozreview: Add parentID to the MozReview object (bug 1304611);

https://reviewboard.mozilla.org/r/80348/#review83078

Comment 8

[Steven MacLeod [:smacleod]]

Comment on attachment 8793632 [details]
mozreview: Add a link to the parent on submitted children (bug 1304611)

https://reviewboard.mozilla.org/r/80350/#review83080

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/0e762089afa4
mozreview: Prevent direct reopening of child requests r=smacleod
https://hg.mozilla.org/hgcustom/version-control-tools/rev/a7adaa7e371f
mozreview: Add parentID to the MozReview object ; r=smacleod
https://hg.mozilla.org/hgcustom/version-control-tools/rev/aa1c1f441e7b
mozreview: Add a link to the parent on submitted children r=smacleod