Add a feature flag for batch upload API

RESOLVED FIXED

Status

Cloud Services
Server: Sync
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: rfkelly, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

a year ago
For initial deployment of the sync Batch Upload API (bug 1250189) we do not want to put it live on all nodes at once.  Rather, we want to roll it out to new nodes while leaving existing nodes to their existing database table structure.

To avoid having multiple different versions of the code deployed in production, let's put the batch upload API behind a configurable feature flag.  New nodes can set the flag on in their config file, old nodes can set it off, and everyone will be happy.
(Reporter)

Comment 1

a year ago
:rtilder, did you have any in-progress code for this?  :natim suggested he may have some cycles spare to help us get this feature over the line, so I'm trying to get a handle on what remains and what parts can be handed off cleanly.
Flags: needinfo?(rtilder)
(Reporter)

Comment 2

a year ago
In this PR:

  https://github.com/mozilla-services/server-syncstorage/pull/45

I've made a feature-flag with the following name:

```
[storage]
batch_upload_enabled = true
```

The feature will only be enabled on boxes with this explicitly set, and is off by default.
Flags: needinfo?(rtilder)
(Reporter)

Comment 3

a year ago
:bobm does this seem reasonable to you?
Flags: needinfo?(bobm)
(In reply to Ryan Kelly [:rfkelly] from comment #3)
> :bobm does this seem reasonable to you?

Yes.
Flags: needinfo?(bobm)
(Reporter)

Comment 5

a year ago
The above-linked PR was merged.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.