1304632 - add some CSS image value assertions

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Cameron McCormack (:heycam)]

A couple of assertions that seemed worth adding while working on stylo background-image support.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1304632 - Part 1: Assert main thread in ImageValue destructor.

The css::ImageValue destructor does things only safe from the main
thread.  Let's assert so that we don't accidentally start releasing them
from style worker threads during restyle.

Review commit: https://reviewboard.mozilla.org/r/80354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80354/

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1304632 - Part 2: Remove unnecessary nsStyleImage::mImage null checking.

nsStyleImage::mImage is always set to a non-null object when its mType
is eStyleImageType_Image, so let's just assert that and stop null
checking in that case.

Review commit: https://reviewboard.mozilla.org/r/80356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80356/

Comment 3

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=128f6222954b&group_state=expanded

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8793637 [details]
Bug 1304632 - Part 1: Assert main thread in ImageValue destructor.

https://reviewboard.mozilla.org/r/80354/#review79108

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8793638 [details]
Bug 1304632 - Part 2: Remove unnecessary nsStyleImage::mImage null checking.

https://reviewboard.mozilla.org/r/80356/#review79110

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f54a85a2b1c9
Part 1: Assert main thread in ImageValue destructor. r=bholley
https://hg.mozilla.org/integration/autoland/rev/d87b0d8129a8
Part 2: Remove unnecessary nsStyleImage::mImage null checking. r=bholley

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f54a85a2b1c9
https://hg.mozilla.org/mozilla-central/rev/d87b0d8129a8