1304698 - Enable mask-image for chrome code in all channels

Status: RESOLVED DUPLICATE of bug 1251161

(Core :: CSS Parsing and Computation, defect)

Description

[Dão Gottwald [:dao]]

Xidorn says this is easy.

We'd like to use mask-image for bug 658467.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This probably just requires CSS_PROPERTY_ENABLED_IN_CHROME on the appropriate properties (probably all of the longhands and the shorthand) in layout/style/nsCSSPropList.h.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

(In reply to David Baron :dbaron: ⌚️UTC+1 (busy September 14-25) from comment #1)
> This probably just requires CSS_PROPERTY_ENABLED_IN_CHROME on the
> appropriate properties (probably all of the longhands and the shorthand) in
> layout/style/nsCSSPropList.h.

That was what I thought. But it seems it is not as easy as that.

I thought the longhands have been behind a runtime pref, only mask as shorthand is not. However, it seems currently all mask longhands are behind a compile flag as well.

Good news is that it seems Ashley has started trying to make it a runtime pref in bug 1301638. Once that finishes, this is simple.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ah, I thought that bug had landed.

Comment 4

[Dão Gottwald [:dao]]

Bug 1301638 looks stalled. Should I wait before moving forward with bug 658467? Is there a timeline for shipping the mask stuff?

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

So it isn't as easy as I thought, and yeah, you probably should wait for that.

And TBH, I was pushing bug 658467 because of bug 898984. That bug was getting more visible due to the bloating of non-BMP characters, especially the popularity of emoji, however, it was not easy to fix the fundamental issue. So I thought fixing bug 658467 would be an easier route to get that bug less visible again.

Now pushed by arai, that bug has been fixed, so I'm not that motivated about fixing bug 658467. I still think that bug is worth fixing on itself (as well as bug 1301638), but maybe at a relatively lower priority :)

Comment 6

[Dão Gottwald [:dao]]

Bug 658467 has been stalled not because of a lack of motivation as far as I'm concerned. It is definitely still wanted, and I don't think the BMP issue (which was undoubtedly an unfortunate bug but also an edge case) being resolved significantly lowers the priority of bug 658467 from a UX perspective.

Of course I'm not saying "drop everything else and focus on making bug 658467 possible", but I do hope it gets unblocked soon.