1304727 - Inspector layout broken if toolbox height is lower than 250px

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Julian Descottes [:jdescottes]]

Attachment: inspector-layout-broken-small-height.png

Regression from inspector.xul migration to HTML (Bug 1262443)

STRs:
- open devtools, docked to bottom
- resize toolbox height to be lower than 250px
- close devtools
- open devtools

AR: Bottom of the toolbox is blank, layout looks buggy (see attachment)
ER: Layout should be correct

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1304727.patch

Thanks for the report Julian!

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

There is also another STR that's fixed by the attached patch:

1) Open the Toolbox, the Inspector should be the default panel
2) Switch to the Network panel, reload the page, select an entry, the side panel should appear
3) Switch back to the Inspector panel, there is a gap at the bottom -> BUG

Honza

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8794174 [details] [diff] [review]
bug1304727.patch

Review of attachment 8794174 [details] [diff] [review]:
-----------------------------------------------------------------

Fixes the issue, thank you Honza!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/d2bacbda0dcd
Fix Inspector layout; r=jdescottes

Comment 5

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/d2bacbda0dcd

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this bug using Fx 52.0a1, build ID:20160922030437, on Windows 10 x64 and Mac OS X 10.10.5.
I can confirm this issue is fixed, I verified using Fx 52.0a1 build ID:20160927030200, on Windows 10 x64, Ubuntu 14.04 LTS and Mac OS X 10.10.5.