Delete unused dom/indexedDB/ActorsParent.cpp copy constructors

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
When building with GCC 6 and --enable-warnings-as-errors, errors like this are encountered:
> /moz/mozilla-inbound/dom/indexedDB/ActorsParent.cpp:13042:1: error: ‘mozilla::dom::indexedDB::{anonymous}::ConnectionPool::IdleThreadInfo::IdleThreadInfo(const mozilla::dom::indexedDB::{anonymous}::ConnectionPool::IdleThreadInfo&)’ defined but not used [-Werror=unused-function]

These point at various unused copy constructors.
While I would prefer not having to remove them, having to carry a local patch just to get a working build is a bit annoying.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8793833 [details]
Bug 1304779 - Delete unused dom/indexedDB/ActorsParent.cpp copy constructors.

https://reviewboard.mozilla.org/r/80456/#review79892

r=me
Attachment #8793833 - Flags: review?(jvarga) → review+
(Assignee)

Updated

a year ago
Blocks: 1305577
(Assignee)

Comment 3

a year ago
Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d10c7341083
Keywords: checkin-needed

Comment 4

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dad990960ba0
Delete unused dom/indexedDB/ActorsParent.cpp copy constructors. r=janv
Keywords: checkin-needed

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dad990960ba0
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.