SyntaxError "'#595, [name='595']' is not a valid selector" in mailWindowOverlay.js while reading newsgroup

RESOLVED FIXED in Thunderbird 52.0

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ssitter, Assigned: alta88)

Tracking

({regression})

Thunderbird 52.0

Thunderbird Tracking Flags

(thunderbird51 fixed, thunderbird52 fixed)

Details

Attachments

(2 attachments)

Posted file news_message.eml
Using Thunderbird 51.0a2 (20160922004009) I get many errors like the following while reading newsgroup messages:

SyntaxError: '#595, [name='595']' is not a valid selector
  OnMsgParsed chrome://messenger/content/mailWindowOverlay.js:3379:10
  messageHeaderSink.onEndMsgDownload chrome://messenger/content/msgHdrViewOverlay.js:731:7

In this example the message contains a link to http://searchfox.org/mozilla-central/source/dom/media/GraphDriver.cpp#595

Original message: news://news.mozilla.org:119/mailman.3594.1474531132.18164.dev-platform@lists.mozilla.org

Other example that trigger a similar error:
news://news.mozilla.org:119/mailman.3542.1474530289.18165.dev-apps-thunderbird@lists.mozilla.org

news://news.mozilla.org:119/O72dnTWju8r6DFDKnZ2dnUU7-U2dnZ2d@mozilla.org
Likely from bug 359183.
Keywords: regression
Posted patch anchor.patchSplinter Review
Remove the anchor target check in mailnewsurl messages, like we did for web pages. If the same page test passes and it's not found, in the same doc, nothing happens which matches the behavior in a browser.
Assignee: nobody → alta88
Attachment #8793904 - Flags: review?(jorgk)
Comment on attachment 8793904 [details] [diff] [review]
anchor.patch

Please provide a correct commit message, for example:
Bug 1304795 - Don't check anchor target existence to avoid invalid selectors. r=jorgk
or words to that effect ;-)
I don't believe that the bug summary should just be copied to the commit message.

Anyway, I can fix that when landing the bug. Do you have Level 3 access?
Attachment #8793904 - Flags: review?(jorgk) → review+
i don't have l3.
Keywords: checkin-needed
Landed.
C-C: https://hg.mozilla.org/comm-central/rev/48d888b2cdc5
C-A: https://hg.mozilla.org/releases/comm-aurora/rev/312ee6460a1e
Status: NEW → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in before you can comment on or make changes to this bug.