1304795 - SyntaxError "'#595, [name='595']' is not a valid selector" in mailWindowOverlay.js while reading newsgroup

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: news_message.eml

Using Thunderbird 51.0a2 (20160922004009) I get many errors like the following while reading newsgroup messages:

SyntaxError: '#595, [name='595']' is not a valid selector
  OnMsgParsed chrome://messenger/content/mailWindowOverlay.js:3379:10
  messageHeaderSink.onEndMsgDownload chrome://messenger/content/msgHdrViewOverlay.js:731:7

In this example the message contains a link to http://searchfox.org/mozilla-central/source/dom/media/GraphDriver.cpp#595

Original message: news://news.mozilla.org:119/[e-mail]

Other example that trigger a similar error:
news://news.mozilla.org:119/[e-mail]

news://news.mozilla.org:119/[e-mail]

Comment 1

[Magnus Melin [:mkmelin]]

Likely from bug 359183.

Comment 2

[alta88]

Attachment: anchor.patch

Remove the anchor target check in mailnewsurl messages, like we did for web pages. If the same page test passes and it's not found, in the same doc, nothing happens which matches the behavior in a browser.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8793904 [details] [diff] [review]
anchor.patch

Please provide a correct commit message, for example:
Bug 1304795 - Don't check anchor target existence to avoid invalid selectors. r=jorgk
or words to that effect ;-)
I don't believe that the bug summary should just be copied to the commit message.

Anyway, I can fix that when landing the bug. Do you have Level 3 access?

Comment 4

[alta88]

i don't have l3.

Comment 5

[Jorg K (CEST = GMT+2)]

Landed.
C-C: https://hg.mozilla.org/comm-central/rev/48d888b2cdc5
C-A: https://hg.mozilla.org/releases/comm-aurora/rev/312ee6460a1e