1304798 - Can't share video at talky.io, if you've previously granted "always allow"

Status: VERIFIED FIXED

(Core :: WebRTC, defect, P1)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit https://talky.io/testing-video-access-bug  (or /whatever-you-want)
 2. Click the camera icon in URLbar
 3. Click dropdown arrow next to "Share selected devices" button
 4. Choose "Always share"
 5. Reload

EXPECTED RESULTS:
After a second or so, Talky.io should detect that it already has camera access and should show me a video preview.

ACTUAL RESULTS:
After you reload, Talky.io shows some UI indicating that it needs you to grant camera privileges. ("Allow camera access to get started", dancing pink camera with an arrow.)  But Firefox does not have any UI for me to satisfy this request -- and if I click the Site ID icon, it shows I've already granted approval.

Current Firefox release (49) gives me EXPECTED RESULTS.
Current Firefox Nightly (52.0a1 (2016-09-22) (64-bit)) gives me ACTUAL RESULTS.

Comment 1

[Daniel Holbert [:dholbert]]

Initial regression range (narrowing):
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4aa20c3e211f6fec5d82bb74b087e13ad7ac04cc&tochange=612a50c5350689a8e465d0a542a37e32613a88bd

bug 1299783 seems most relevant in that range - its commit message mentions camera permissions.

Comment 2

[Daniel Holbert [:dholbert]]

Yup, just made it to the end of mozregression and it gave me this range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=675331e308773c07e5b39cafd92ec1f4f591d152&tochange=c1e0b205c39b8946dfb485c0ecee7a5bc640815c
...which is bug 1299783.

Comment 3

[Florian Quèze [:florian]]

Meh, I have lots of tests for persistent permissions, I would have thought this was covered :-(. Sorry.

Comment 4

[Florian Quèze [:florian]]

Attachment: Fix

This fixes the problem... but I still want to figure out why the tests didn't catch this. Will probably do the test fix in a separate attachment and request review from a browser peer for it though.

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/b24f7037ccca54598b877b63617199fd989bbc98
Bug 1304798 - Fix opening video streams for pages with persistent permissions, r=gcp.

Comment 6

[Florian Quèze [:florian]]

(In reply to Florian Quèze [:florian] [:flo] from comment #4)

> I still want to figure out why the tests didn't catch this.

It seems to be that the fake devices used by tests don't require the MediaManagerVideo permission to be set to allow opening the stream, so I'm afraid there's not much I can do in the test to catch this.

Comment 7

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/b24f7037ccca

Comment 8

[ovidiu boca[:Ovidiu]]

Tested with Firefox Nightly 52.0a1 (2016-10-05) and I can verify the fix.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

The fix for this was included in the roll-up patch for bug 1299783.