1304887 - hg push review fails with: running checkstyle...abort: %1 is not a valid Win32 application.

Status: RESOLVED FIXED

(MozReview Graveyard :: Integration: Mercurial, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Tried to push from a mozilla-central repo to reviewboard, but it failed:

$ hg push review
pushing to ssh://reviewboard-hg.mozilla.org/autoreview/
searching for appropriate review repository
redirecting push to ssh://reviewboard-hg.mozilla.org/gecko
running checkstyle...abort: %1 ist keine zulõssige Win32-Anwendung

Translation of the last line is:
running checkstyle...abort: %1 is not a valid Win32 application.

I have successfully pushed to reviewboard in the past. The machine runs Windows 8.1 64 bit + MozillaBuild 2.2.0.

Comment 1

[:glob ✱]

we run checkstyle when android code is changed (via bug 1263201).
perhaps we should treat OSError exceptions as non-fatal.

aryx, can you try running checkstyle manually to see if it produces the same error:
./mach gradle checkstyle

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

|./mach gradle checkstyle| exits with:
> It looks like you tried to run a mach command from an invalid context. The gradle
> command failed to meet the following conditions:
> 
>   is_android - Must have an Android build.
> 
> Run |mach help| to show a list of all commands available to the current context.

Comment 3

[Gregory Szorc [:gps]]

`mach` isn't a valid win32 executable: it is a shell/Python script. We need to execute `mach` via bash.exe or python.exe.

Comment 4

[Brian Birtles (:birtles)]

I'm hitting this now even though the changeset I'm pushing doesn't not modify any android code.

I suppose it might be because I rebased on top of autoland and there are some changesets on autoland that touch android code?

Comment 5

[Brian Birtles (:birtles)]

Confirmed that rebasing on top of central (instead of autoland) and pushing again works.

Comment 6

[Brian Birtles (:birtles)]

Glob, can we please make this P1? It's a real blocker to doing work on Windows especially since we often need to rebase MozReview requests on top of autoland for Stylo work (to generate up-to-date bindings etc.).

Comment 7

[:glob ✱]

caught brian on irc...

we're running ['c:\\moz\\src1/gradlew', '--quiet', '--project-dir', 'c:\\moz\\src1', 'app:checkstyle']
which is throwing: [Error 193] %1 is not a valid Win32 application

so it looks like something in the gradlew wrapper is incorrect for our env.
the investigations continue.

Comment 8

[:glob ✱]

pans out error win32 messages are misleading; it should be reporting that "c:\\moz\\src1/gradlew" is not a valid win32 application.

Comment 9

[:glob ✱]

Attachment: reviewboard: run gradlew with bash (bug 1304887)

Explicitly use bash to run gradlew to allow it to run on Windows.
Additionally treat failures to run gradlew as non-fatal.

Review commit: https://reviewboard.mozilla.org/r/159132/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159132/

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 8888194 [details]
reviewboard: run gradlew with bash (bug 1304887)

https://reviewboard.mozilla.org/r/159132/#review165802

Comment 11

[:glob ✱]

Comment on attachment 8888194 [details]
reviewboard: run gradlew with bash (bug 1304887)

https://reviewboard.mozilla.org/r/159132/#review166046

Comment 12

[:glob ✱]

Comment on attachment 8888194 [details]
reviewboard: run gradlew with bash (bug 1304887)

oops; someone needs more coffee.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/7239bee71bae
reviewboard: run gradlew with bash r=gps