1304913 - stylo: Manage servo node data directly from Servo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Bobby Holley (:bholley)]

This is a prerequisite to our new TSD-based infrastructure, and saves us some FFI calls. I have a patch.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Update the regen script to use the new bindgen.

Review commit: https://reviewboard.mozilla.org/r/80568/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80568/

Comment 2

[Bobby Holley (:bholley)]

Attachment: Regen bindings and build fixes.

Review commit: https://reviewboard.mozilla.org/r/80570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80570/

Comment 3

[Bobby Holley (:bholley)]

Attachment: Regenerate bindings.

Review commit: https://reviewboard.mozilla.org/r/80572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80572/

Comment 4

[Bobby Holley (:bholley)]

Attachment: Blacklist atomic___base.

This should be upstream shortly.

Review commit: https://reviewboard.mozilla.org/r/80574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80574/

Comment 5

[Bobby Holley (:bholley)]

Attachment: Bug 1304913 - Have Servo manage node data directly without FFI calls. v1

Review commit: https://reviewboard.mozilla.org/r/80576/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80576/

Comment 6

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d99cb6d94f76

Comment 7

[Manish Goregaokar [:manishearth]]

Comment on attachment 8794005 [details]
Bug 1304913 - Have Servo manage node data directly without FFI calls. v1

https://reviewboard.mozilla.org/r/80576/#review79384

If it's easy to do, could you separate out the other bindings changes from the node data stuff?

Also there should probably be a comment somewhere explaining that the node data is safe to manipulate this way because it is only mutated when created, and there are only reads after that. Not sure if we can enforce this with types or something.

Comment 8

[Bobby Holley (:bholley)]

(In reply to Manish Goregaokar [:manishearth] from comment #7)
> Comment on attachment 8794005 [details]
> Bug 1304913 - Have Servo manage node data directly without FFI calls. v1
> 
> https://reviewboard.mozilla.org/r/80576/#review79384
> 
> If it's easy to do, could you separate out the other bindings changes from
> the node data stuff?

I will try.

> Also there should probably be a comment somewhere explaining that the node
> data is safe to manipulate this way because it is only mutated when created,
> and there are only reads after that. Not sure if we can enforce this with
> types or something.

I did some fruitful investigation here, and filed bug 1305141 about it.

Comment 9

[Bobby Holley (:bholley)]

Non-stylo try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=02307c8a28de

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfc1afe56b75
Have Servo manage node data directly without FFI calls. r=Manishearth

Comment 11

[Bobby Holley (:bholley)]

Servo PR: https://github.com/servo/servo/pull/13404

Comment 12

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/dfc1afe56b75