Closed Bug 1304913 Opened 3 years ago Closed 3 years ago

stylo: Manage servo node data directly from Servo

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(5 files)

This is a prerequisite to our new TSD-based infrastructure, and saves us some FFI calls. I have a patch.
Attachment #8794005 - Flags: review?(manishearth)
Attachment #8794001 - Flags: review?(manishearth)
Attachment #8794001 - Flags: review?(manishearth)
Comment on attachment 8794005 [details]
Bug 1304913 - Have Servo manage node data directly without FFI calls. v1

https://reviewboard.mozilla.org/r/80576/#review79384

If it's easy to do, could you separate out the other bindings changes from the node data stuff?

Also there should probably be a comment somewhere explaining that the node data is safe to manipulate this way because it is only mutated when created, and there are only reads after that. Not sure if we can enforce this with types or something.
Attachment #8794005 - Flags: review?(manishearth) → review+
(In reply to Manish Goregaokar [:manishearth] from comment #7)
> Comment on attachment 8794005 [details]
> Bug 1304913 - Have Servo manage node data directly without FFI calls. v1
> 
> https://reviewboard.mozilla.org/r/80576/#review79384
> 
> If it's easy to do, could you separate out the other bindings changes from
> the node data stuff?

I will try.

> Also there should probably be a comment somewhere explaining that the node
> data is safe to manipulate this way because it is only mutated when created,
> and there are only reads after that. Not sure if we can enforce this with
> types or something.

I did some fruitful investigation here, and filed bug 1305141 about it.
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfc1afe56b75
Have Servo manage node data directly without FFI calls. r=Manishearth
https://hg.mozilla.org/mozilla-central/rev/dfc1afe56b75
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.