1304926 - Enable 25519 key exchange

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P2)

Description

[Martin Thomson [:mt:]]

We currently leave the default groups enabled, which could be problematic on some systems, particularly for performance.

When doing so, we should also ensure that we call SSL_SendAdditionalKeyShares so that we generate P-256 shares as well as 25519 shares.  That will affect TLS 1.3 when that's enabled, and we could miss it (there is a theory that all the servers will have 25519, but that's not certain yet).

Recommended groups and their order: 25519, P-256, P384, FFDHE2048, FFDHE3072.

Comment 1

[Martin Thomson [:mt:]]

Attachment: Bug 1304926 - Enable specific named groups,

Review commit: https://reviewboard.mozilla.org/r/81040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81040/

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8794709 [details]
Bug 1304926 - Enable specific named groups,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/81040/diff/1-2/

Comment 3

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8794709 [details]
Bug 1304926 - Enable specific named groups,

https://reviewboard.mozilla.org/r/81040/#review79758

LGTM once enough of bug 1304919 lands.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27e8b32dea3e
Enable specific named groups, r=keeler

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/27e8b32dea3e