1304961 - Add buffered ranges to information gathered by external media tests

Status: RESOLVED FIXED

(Testing Graveyard :: external-media-tests, defect)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

VideoPuppeteer does not current query the buffered ranges of the wrapped video element. This information would be useful for debugging and diagnosing test failures, such as stalls.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1304961 - Rename variables storing played ranges to be more specific.

The played ranges being retrieved in VideoPuppeteer and YoutubePuppeteer were
often referenced as some variation of 'time ranges'. This patch makes that more
specific and references the played ranges as variations of 'played ranges'. This
removes ambiguity if other time ranges are retrieved in future, such as the
buffered ranges.

Review commit: https://reviewboard.mozilla.org/r/80668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80668/

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1304961 - Retrieve buffered ranges in VideoPuppeteer.

Update VideoPuppeteer and make small changes in YoutubePuppeteer to support
retrieval of buffered ranges for wrapped video element. This will help diagnose
test failures, particularly stalls we're having at the moment. Because the
namedtuple storing state has all its fields logged the __str__ methods of the
puppeteers don't need to be updated, the new field will be logged automatically.

Review commit: https://reviewboard.mozilla.org/r/80670/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80670/

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8794061 [details]
Bug 1304961 - Rename variables storing played ranges to be more specific.

https://reviewboard.mozilla.org/r/80668/#review79406

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8794062 [details]
Bug 1304961 - Retrieve buffered ranges in VideoPuppeteer.

https://reviewboard.mozilla.org/r/80670/#review79416

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9efa0b30eab2
Rename variables storing played ranges to be more specific. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/89fc0a741450
Retrieve buffered ranges in VideoPuppeteer. r=maja_zf

Comment 6

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/9efa0b30eab2
https://hg.mozilla.org/mozilla-central/rev/89fc0a741450