Closed Bug 1304973 Opened 3 years ago Closed 3 years ago

Identity popup expander button shouldn't have a white gradient in the background unless hovered

Categories

(Firefox :: Site Identity, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The gradient is invisible with default themes (because the panel background is white) and it looks wrong in dark themes such as high contrast themes.
Attachment #8794090 - Flags: review?(florian)
Blocks: 1170759
Comment on attachment 8794090 [details] [diff] [review]
patch

Review of attachment 8794090 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me, but I couldn't test high contrast mode, so I trust your "it looks wrong in dark themes such as high contrast themes" statement from comment 0. It would be nice to have a screenshot in such a bug report about a visual issue.
Attachment #8794090 - Flags: review?(florian) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58d45ed78ffe
Identity popup expander button shouldn't have a white gradient in the background unless hovered. r=florian
https://hg.mozilla.org/mozilla-central/rev/58d45ed78ffe
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.