1305009 - firefox/channel/*/ Learn more paragraph links translations shouldn't be taken from main.lang

Status: NEW

(www.mozilla.org :: Pages & Content, defect)

Description

[Stefan Plewako [:stef]]

On https://www-demo1.allizom.org/pl/firefox/channel/desktop/

    Firefox Beta automatically sends feedback to Mozilla. Learn more
    Firefox Developer Edition automatically sends feedback to Mozilla. Learn more
    Firefox Nightly automatically sends feedback to Mozilla. Learn more

On https://www-demo1.allizom.org/pl/firefox/channel/android/

    Firefox Beta automatically sends feedback to Mozilla. Learn more
    Firefox Aurora automatically sends feedback to Mozilla. Learn more

"Learn more" links translations are incorrectly taken from general file - as part of paragraph translation they should be in firefox/channel/index.lang file.

"Learn more" from main.lang is translated as stand alone string and on firefox/channel/*/ it clearly isn't stand alone but part of the sentence. Example of how it should be done could be spotted on https://www-dev.allizom.org/pl/firefox/channel/ and https://github.com/mozilla-l10n/www.mozilla.org/blob/master/en-US/firefox/channel.lang#L32

Comment 1

[Francesco Lodolo [:flod]]

As explained in the original issue, I still don't understand what the problem is.

In main.lang "Learn more" is translated as "Więcej informacji". You ask "Learn more" to be part of the full string, like it used to be in the previous version of the page.

Old channel page had one string:

;Firefox Beta automatically sends feedback to Mozilla. <a href="%(link)s">Learn more</a>.
Firefox Beta automatycznie wysyła informacje do Mozilli. <a href="%(link)s">Więcej informacji</a>.

New channel page has that sentence split in two strings

(from firefox/channel/index.lang)
;Firefox Beta automatically sends feedback to Mozilla.
Firefox Beta automatycznie przesyła statystyki użytkownika do Mozilli.

(from main.lang)
;Learn more
Więcej informacji

So, I'll ask again: how would the translation change if you had only one string for the full sentence? Is the problem the missing period? Or it would be enough to have the string "Learn more" exposed in firefox/channel/index.lang?

Comment 2

[Francesco Lodolo [:flod]]

OK, I missed the last comment in
https://github.com/mozilla-l10n/www.mozilla.org/issues/109

So, it's about the final period.

The problem is that I don't want to disrupt the translation started for all other locales. Would it be enough to have "Learn more" exposed in the .lang file, so you can add the "." in your translation? It would be obviously part of the link, but still better than not having it all.

Changing the entire strings for a period is not an option at this point.

Comment 3

[Stefan Plewako [:stef]]

Yes, this is about the final period in that particular case and let's not disrupt the process. I'm fine with a proper fix after translation window, next time when strings will be updated.

Just please don't use period as part of the link and fix it properly with placeholder or something - it doesn't need to be a part of exact paragraph string for pl.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Stefan Plewako [:stef] from comment #3)
> Just please don't use period as part of the link and fix it properly with
> placeholder or something - it doesn't need to be a part of exact paragraph
> string for pl.

There's no way to add a period outside of the link just for Polish. We can either keep the current situation (no period) and wait for the strings to change (it won't happen until we have other changes in the page), or expose "Learn more" so that you can use 'Więcej informacji.' as translation for this specific page.

Comment 5

[Stefan Plewako [:stef]]

(In reply to Francesco Lodolo [:flod] from comment #4)
> There's no way to add a period outside of the link just for Polish.

Just for Polish? I'm not asking about such thing. Just stated that as far as Polish is concerned (don't know about other locales), the learn more link on new channel pages could be one additional string (like '<a href="%(link)s">Learn more</a>.') for all paragraphs.

> We can either keep the current situation (no period) and wait for
> the strings to change (it won't happen until we have other changes in the page)

I'm fine if that will happen in reasonable time, like with next strings export for mozilla.org.

> or expose "Learn more" so that you can use 'Więcej informacji.'

Please don't do that.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Stefan Plewako [:stef] from comment #5)
> Just for Polish? I'm not asking about such thing. Just stated that as far as
> Polish is concerned (don't know about other locales), the learn more link on
> new channel pages could be one additional string (like '<a
> href="%(link)s">Learn more</a>.') for all paragraphs.
That's a new string, and falls back to the other case (exposing the entire sentence as a new string).

On timing: it's going to happen at the first change of strings for this page, so it will take a while. That's why I was suggestive the other alternative in the meantime.

Comment 7

[Stefan Plewako [:stef]]

It's beyond my knowledge why and how this works so badly but the proper fix is the way to go even if it will take a while.