1305019 - DAV calendar corruption when closing thunderbird with an open reminder window

Status: NEW

(Calendar :: Provider: ICS/WebDAV, defect, P3)

Description

[Alberto Capuzzo]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160623154057

Steps to reproduce:

Close TB while a reminder window was still opened, then closed the reminder window.


Actual results:

A calendar corruption occurs. 

On the http server access_log I find:
192.168.1.46 - - [23/Sep/2016:09:45:12 +0200] "PUT /agenda/monica_2015_09_07.ics HTTP/1.1" 500 612 "-" "Mozilla/5.0 (Windows NT 5.1; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 Lightning/4.7.3"

In error_log: [Fri Sep 23 09:45:12 2016] [error] [client 192.168.1.46] Could not get next bucket brigade  [500, #0]




Expected results:

Obviously I expected no corruption. Such a calendar corruption is an issue that my colleagues experienced several times randomly in the past, with present and older versions of TB & Lightning, and reported me, but before today it never occurred while I was present. Today finally the issue occured while I was present, so I could trace events and understand the exact process that determines the corruption.

I can add that if you close TB with the reminder opened, then re-open TB without closing the reminder, everything seems to work correctly (well, maybe because while the reminder window is opened TB process doesn't actually terminates but remains in background?).

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

I thought we included code to trigger that last window closing area, but it seems it is not working. We should be postponing the quit until the write has succeeded. It would probably be equally good to use a more general mechanism we can re-use in other providers. I can imagine this would happen similarly with caldav requests.