1305035 - Crash in @ mozilla::WebGLTexture::CompressedTexImage

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Bogdan Maris, Desktop Test Engineering]

This bug was filed from the Socorro interface and is 
report bp-b1485431-8530-4162-8db0-78f522160922.
=============================================================

[Affected versions]:
- latest Developer Edition 51.0a2
- latest Nightly 52.0a1

[Affected platforms]:
- Mac OS X 10.10.5
- Mac OS X 10.11.6
- Mac OS X 10.12

[Steps to reproduce]:
1. Start Firefox
2. Visit http://webglsamples.org/WebGL2Samples/
3. Click on texture_etc2_eac demo

[Expected result]:
- Demo is properly displayed

[Actual result]:
- Tab crashes

[Regression range]:
- Don't know if this is a regression, will check ASAP.

[Additional notes]:
- Needinfo-ing me so it stays on my radar for finding regression.
- Other crash reports with similar or same signatures:
bp-b1485431-8530-4162-8db0-78f522160922
bp-3885da3a-55e7-45e4-88e4-b389e2160922
bp-1c4b074a-a420-4586-af80-b610a2160922
bp-d7cc2bb5-f492-4532-9cec-200f12160922
bp-2fba0932-4f7c-4acb-a0d4-ae90e2160922
bp-dcea9c08-decc-45d8-8e32-bedb32160922
bp-26c1a120-4750-4fbb-b598-87b582160922
bp-0e18d58f-f789-46b0-a59d-0b0952160922
bp-71a89134-d766-4a35-86ed-b3e3b2160922
bp-803a816f-e9a3-4665-afef-2394d2160922
bp-d3dd1a35-5cb4-41c6-862a-6a0112160922
bp-0915425f-2103-4d83-b7cc-485652160923

Comment 1

[Jeff Muizelaar [:jrmuizel]]

None of these crash reports have symbols which makes them basically useless. What build were you using to get these crashes?

Comment 2

[Bogdan Maris, Desktop Test Engineering]

I used the latest Developer Edition build from 2016-09-22 (https://archive.mozilla.org/pub/firefox/nightly/2016/09/2016-09-22-00-40-07-mozilla-aurora/firefox-51.0a2.en-US.mac.dmg) also Nightly from the same date.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Missing Mac symbols is bug 1301751. That said, I can't reproduce the crash on Windows :(

Comment 4

[Bogdan Maris, Desktop Test Engineering]

I used mozregression to find the regression here. I considered 'good revision' the builds where it did not crash but the demo did not display anything. Here are the results:

Last good revision: b40623c581c95fff14dda74465a42d2190e9ad67
First bad revision: b957e4b64c2bbb0de38c66cb89f91578d95d204c

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b40623c581c95fff14dda74465a42d2190e9ad67&tochange=b957e4b64c2bbb0de38c66cb89f91578d95d204c

Based on the pushlog, looks like the following bug has the changes which introduced the regression:

https://bugzilla.mozilla.org/show_bug.cgi?id=1285117

Comment 5

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Crash using webgl2, which we're aiming to ship in 50.

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

WebGL2 related crash, tracked for 50+

Comment 7

[Gerry Chang [:gchang]]

Track 51+ as WebGL2 related crash.

Comment 8

[Marcia Knous [:marcia]]

Track this for 52+. We can reprocess the crashes if needed.

Comment 9

[Jet Villegas (inactive)]

Jeff: Can you comment on this one and related WebGL2 release criteria? Thx!

Comment 10

[Kelsey Gilbert [:jgilbert]]

I believe this is fixed by bug 1306174.

Comment 11

[Kelsey Gilbert [:jgilbert]]

Please retest!

Comment 12

[Bogdan Maris, Desktop Test Engineering]

I can no longer reproduce the crash using latest Nightly 52.0a1 and latest Developer Edition 51.0a2 on Mac OS X 10.12 and 10.11.6 so I will go ahead and close this as fixed due to fix from bug 1306174.