Closed Bug 1305059 Opened 5 years ago Closed 4 years ago
Focus ring on the match searches that contains link
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20160922030437 [Affected versions]: - Nightly 52.0a1 [Affected platforms]: - Windows 10, Ubuntu 16.04, Mac OS X 10.11 [Steps to reproduce]: 1. Visit: https://wiki.mozilla.org/Main_Page 2. Ctrl+F to open the Find bar 3. Search for "project" [Expected result]: - The search results that contains a link should be highlighted the same way as any search (without links) is. [Actual result]: - A focus ring is displayed on the search result that contains a link. Please see the screenshot for more details. [Regression range]: - I'll investigate this as soon as possible and post back the results. [Additional notes]: - The focus ring is not present if the preferences "findbar.modalHighlight" and "findbar.highlightAll" are set to false.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8917851 [details] Bug 1305059 - Adhere to the 'drawOutline' option as passed in by the Finder to decide whether an outline should be visible. https://reviewboard.mozilla.org/r/188792/#review194198 I looked on searchfox but don't see where drawOutline ever gets set to true or false (http://searchfox.org/mozilla-central/search?q=drawoutline&path=) Can you point me to that code?
Attachment #8917851 - Flags: review?(jaws) → review+
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3) > I looked on searchfox but don't see where drawOutline ever gets set to true > or false (http://searchfox.org/mozilla-central/search?q=drawoutline&path=) > Can you point me to that code? You can see that `drawOutline` gets passed into the `options` dictionary in Finder.jsm and RemoteFinder.jsm set to `aDrawOutline`, which is the third argument of the 'fastFind' and 'findAgain' methods. These two methods are invoked by the findbar.xml binding.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/66b011b6b2af Adhere to the 'drawOutline' option as passed in by the Finder to decide whether an outline should be visible. r=jaws
Tested on Nightly 58.0a1 Build ID 20171025230440 on Windows 10, Ubuntu 16.04, Mac OS X. I can confirm the fix. Now, the search results that contains a link is highlighted the same way as any search (without links). I will mark this as Verified - Fixed. Thank you.
You need to log in before you can comment on or make changes to this bug.