1305097 - Baldr: Enhance error reporting from the ToAST transformation

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

[Tracking Requested - why for this release]:

When there's a validation error in the module we're trying to print as text (using the devtools), we can instacrash the shell/browser.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: error-reporting.patch

Another big change: the binary-to-ast transform should in my opinion validate the module it's spitting output for.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

An example of crash report: https://crash-stats.mozilla.com/report/index/0ebe2868-c51b-43ac-aa75-bb8052160923

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 8794303 [details] [diff] [review]
error-reporting.patch

Review of attachment 8794303 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed, thanks!

Comment 4

[Gerry Chang [:gchang]]

Track for 51+ as this is wasm related.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89beb6c945b3
Enhance error reporting from the ToAST transformation; r=luke

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

Thankfully, the 0xc patch fixed most of those, so I (almost) just had to add the error test.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/89beb6c945b3

Comment 8

[Gerry Chang [:gchang]]

Hi :bbouvier,
Since this also affects 51, do you think the patch is worth uplifting to 51?

Comment 9

[Benjamin Bouvier [:bbouvier] (inactive)]

Hi :gchang,
WebAssembly is getting pushed back a bit, so no strong need to get this uplifted to 51. I think it's safe to not track this bug and let it ride the trains instead.
Thanks for the ping though!