Closed Bug 1305126 Opened 3 years ago Closed 3 years ago

Allow try pushes from an aurora tree to get useful l10n results.

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(firefox51 fixed, firefox52 wontfix)

RESOLVED FIXED
Tracking Status
firefox51 --- fixed
firefox52 --- wontfix

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(1 file)

With https://wiki.mozilla.org/ReleaseEngineering/TryServer#Desktop_l10n_jobs (and android) in place, now pushes to try from aurora could trigger l10n jobs.

These jobs will fail to do as expected for a few reasons.
 * The locale repo clones will come from central l10n repos, not aurora, and fail due to missing repos (c.f. Bug 1305061 )
 * The actual english binary pulled will be from central (if we even get that far) due to the configs.

While the configs themselves are sub-optimal, and that this patch itself won't survive the next uplift, while I was in touching these configs for 1305061 I figured I might as well make a push to try for aurora still work for l10n.
(marking status firefox-52 explicitly as wontfix, for this bug, since the patch is only for gecko 51 (aurora) )

It could just as easily land with a seperate bug on Gecko 52 once that uplifts to aurora though.
Comment on attachment 8794359 [details]
Bug 1305126 - Allow try pushes from an aurora tree to get useful l10n results.

https://reviewboard.mozilla.org/r/80850/#review79518

This works.  They'd have to be changed every merge day, which isn't an ideal solution.

A longer term solution might involve something like:

config['tree_specific_config'] = {
    "aurora": {
        "en_us_binary_url": "http://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-aurora",
        ...
    },
    ...
}

and then a way to point at the right tree for that information.  That might allow us to also reduce the number of single locale configs in general.

Alternately, since we already have a mozilla-aurora.py, if we can launch try with --cfg single_locale/mozilla-aurora.py --cfg single_locale/try.py, that could work for everything but the hg repo.

Just brainstorming.  I think this patch is fine for now.
Attachment #8794359 - Flags: review?(aki) → review+
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.