Crash in deqp/functional/gles3/draw/random.html

RESOLVED FIXED in Firefox 51

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

(Blocks 1 bug)

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed, firefox52 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
No description provided.
Comment hidden (mozreview-request)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8794443 [details]
Bug 1305190 - Fix vertex attrib elem size calculations. -

https://reviewboard.mozilla.org/r/80918/#review79582

::: dom/canvas/moz.build:160
(Diff revision 1)
>      'WebGLValidateStrings.cpp',
>      'WebGLVertexArray.cpp',
>      'WebGLVertexArrayFake.cpp',
>      'WebGLVertexArrayGL.cpp',
>      'WebGLVertexArrayObject.cpp',
> +    'WebGLVertexAttribData.cpp',

I don't see WebGLVertexAttribData.cpp in the patch.

Comment 3

3 years ago
mozreview-review
Comment on attachment 8794443 [details]
Bug 1305190 - Fix vertex attrib elem size calculations. -

https://reviewboard.mozilla.org/r/80918/#review79584
Comment hidden (mozreview-request)

Comment 5

3 years ago
mozreview-review
Comment on attachment 8794443 [details]
Bug 1305190 - Fix vertex attrib elem size calculations. -

https://reviewboard.mozilla.org/r/80918/#review79862
Attachment #8794443 - Flags: review?(ethlin) → review+
Assignee

Updated

3 years ago
Blocks: 1306454

Comment 6

3 years ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d50320d6916
Fix vertex attrib elem size calculations. - r=ethlin

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0d50320d6916
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee

Comment 8

3 years ago
Comment on attachment 8794443 [details]
Bug 1305190 - Fix vertex attrib elem size calculations. -

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:
Attachment #8794443 - Flags: approval-mozilla-aurora?
Comment on attachment 8794443 [details]
Bug 1305190 - Fix vertex attrib elem size calculations. -

WebGL 2 is the feature we want to ship in 51. Aurora51+.
Attachment #8794443 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.