Closed
Bug 1305202
Opened 8 years ago
Closed 8 years ago
Use NullString more where appropriate, and don't Truncate where already SetIsVoiding.
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: wisniewskit, Assigned: wisniewskit)
Details
Attachments
(1 file)
|
10.71 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
There are a few places where we might as well use NullString() instead of making a new string and voiding it. There are also a few places where we might as well not Truncate() since we're already doing a SetIsVoid(true). Here's a patch making those things so. Try seems alright with it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=55456556fc43
Attachment #8794461 -
Flags: review?(bugs)
|
||
Updated•8 years ago
|
Attachment #8794461 -
Flags: review?(bugs) → review+
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/db4aece012b7 Use NullString() more and remove superfluous Truncates(). r=smaug
Keywords: checkin-needed
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/db4aece012b7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•