1305223 - browser/components/originattributes/test/browser/browser_sharedworker.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Status: NEW

(Core :: DOM: Security, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/logviewer.html#?job_id=3990964&repo=autoland

[task 2016-09-24T06:50:42.136829Z] 06:50:42     INFO -  193 INFO Starting the test for containers
[task 2016-09-24T06:50:42.166593Z] 06:50:42     INFO -  194 INFO TEST-PASS | browser/components/originattributes/test/browser/browser_sharedworker.js | Testing containers for isolation off with TabSettingA 0 and tabSettingB 0, resultA = 0.6264665690768078, resultB = 0.6264665690768078 -
[task 2016-09-24T06:50:42.171237Z] 06:50:42     INFO -  195 INFO TEST-PASS | browser/components/originattributes/test/browser/browser_sharedworker.js | Testing containers for isolation on with TabSettingA 0 and tabSettingB 1, resultA = 0.17070166144970556, resultB = 0.9915356549219065 -
[task 2016-09-24T06:50:42.172856Z] 06:50:42     INFO -  196 INFO Leaving test bound
[task 2016-09-24T06:50:42.178605Z] 06:50:42     INFO -  197 INFO TEST-UNEXPECTED-FAIL | browser/components/originattributes/test/browser/browser_sharedworker.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Comment 1

[Ethan Tseng [:ethan]]

Dave and Tim, could you take a look of this bug? Is it related to our recent changes to SharedWorkers?

Comment 2

[Dave Huseby [:huseby]]

This appears to be a case where requesting a longer timeout is required.  If we're not going that way, then we'll need to change the runTests() function to take a parameter that defines which of three different test scenarios that the test framework tests.

For instance, I would change TEST_MODE_FIRSTPARTY, TEST_MODE_NO_ISOLATION, and TEST_MODE_CONTAINERS to be bit flags in a parameter for the runTests() function like so:

let tests_to_run = TEST_MODE_FIRSTPARTY | TEST_MODE_NO_ISOLATION;
IsolationTestTools.runTests(TEST_URL, doTest, doCheck, doBefore, tests_to_run);

This way, you can break up the shared worker test into three different files, one passes TEST_MODE_FIRSTPARTY, the second passes TEST_MODE_NO_ISOLATION, and the third passes TEST_MODE_CONTAINERS as the test to run.  That should, in theory, cut the time to run the test down to 1/3 of the time it takes now.

Comment 3

[Dave Huseby [:huseby]]

Attachment: WIP modify test framework to allow tests to specify test scenarios

this WIP modifies the isolation test framework so that tests can limit which test scenarios get run.  this allows tests to hopefully take less time by avoiding running everything.

Comment 4

[Ethan Tseng [:ethan]]

Dave, you are not going to keep looking into this bug, are you?

Comment 5

[Dave Huseby [:huseby]]

Not right now.

Comment 6

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.