Closed Bug 1305309 Opened 3 years ago Closed 3 years ago

Switching between Portrait and Landscape in Print Preview adds extra pages to PDFs

Categories

(Core :: Print Preview, defect)

51 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla52
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 + verified
firefox52 --- verified

People

(Reporter: epinal99-bugzilla2, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

STR:
1) Open the attached PDF
2) Print Preview
3) Switch to Landscape
NB: extra page added
4) Close
5) Print Preview
6) Switch to Portrait
NB: extra page added

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=22990bbee8a830115c0e4084bbd701d71391e43b&tochange=e0a69d89f773dfa1a5f680ce67ce43892f91426d

Olli Pettay — Bug 1214805, allow navigating when afterprint event is dispatched, r=bz
Blocks: 1214805
Has Regression Range: --- → yes
Has STR: --- → yes
Flags: needinfo?(bugs)
Keywords: regression
Bah, I'll backout bug 1214805-
Flags: needinfo?(bugs)
Attached patch backout patchSplinter Review
Assignee: nobody → bugs
Comment on attachment 8795042 [details] [diff] [review]
backout patch

Approval Request Comment
[Feature/regressing bug #]: bug 1214805
[User impact if declined]: See the title of this bug
[Describe test coverage new/current, TreeHerder]: NA
[Risks and why]: Just brings back the old behavior we've had for years
[String/UUID change made/needed]: NA
Attachment #8795042 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/678cd6e8be91 - landed two days ago
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment on attachment 8795042 [details] [diff] [review]
backout patch

Fix a regression related to print preview. Take it in 51 aurora.
Attachment #8795042 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Track 51+ as regression.
Flags: qe-verify+
I've reproduced the initial issue on Nightly 52.0a1 (2016-09-25). 

Verified fixed on Windows 7 x64 and Windows 10 x86 using Firefox 51 Beta 9 (buildID: 20161219140923) and latest Aurora 52.0a2 (buildID: 20161219004024): no extra pages are added to PDF. I saw that switching between Portrait and Landscape in Print Preview replaces PDFs by a blank page , but this is bug 1308461.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.