Open
Bug 1305346
Opened 8 years ago
Updated 4 years ago
[Pointer Events] Make `pointerId` a mandatory parameter when creating Widget Mouse Events and its subclasses.
Categories
(Core :: DOM: UI Events & Focus Handling, enhancement, P3)
Core
DOM: UI Events & Focus Handling
Tracking
()
NEW
People
(Reporter: bhsu, Unassigned)
References
(Blocks 1 open bug)
Details
Now, we always first create a widget mouse event (and its sub-classes), and then assign the pointerId afterward. In this pattern, we largely rely on the default value to assign the value for us, and it's error-prone.
Since `pointerId` is basically comes from the platform, I suggest we should make `pointerId` a const member in widget mouse event and its sub-classes, and only assign the value on its creation. By doing this, we can make the code way more clear.
Reporter | ||
Comment 1•8 years ago
|
||
Here is the WIP patches, where they can be successfully compiled on Windows, Osx, and Linux, and work well on my surface pro. Any comment and suggestion are greatly appreciated :)
https://github.com/driftersprt/gecko-dev/commits/1305346
Assignee: nobody → bhsu
Updated•7 years ago
|
Priority: -- → P2
Updated•7 years ago
|
Assignee: bhsu → nobody
Updated•6 years ago
|
Assignee: nobody → echen
Assignee | ||
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
Updated•4 years ago
|
Assignee: echen → nobody
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•