Closed
Bug 1305362
Opened 8 years ago
Closed 8 years ago
[e10s] should not focus on the disabled option for <select>
Categories
(Toolkit :: UI Widgets, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: over68, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
716 bytes,
patch
|
Details | Diff | Splinter Review | |
|
6.92 KB,
patch
|
bytesized
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce: 1. Go to https://dl.dropboxusercontent.com/u/95157096/85f61cf7/11qokgb995.html. 2. Open the <select> element. 3. Hover over "Option B". Expected results: should not focus on the disabled option for <select> element when hovering.
|
||
Updated•8 years ago
|
Blocks: e10s-select
status-firefox49:
--- → wontfix
status-firefox50:
--- → wontfix
status-firefox51:
--- → affected
status-firefox52:
--- → affected
|
|
||
Comment 1•8 years ago
|
||
Neil, any time for this?
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → enndeakin
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(enndeakin)
OS: Windows 7 → Windows
Hardware: x86_64 → Unspecified
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa4a010a70ab
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8798040 -
Flags: review?(dao+bmo)
|
|
Assignee | |
Updated•8 years ago
|
Component: Layout: Form Controls → XUL Widgets
Product: Core → Toolkit
(In reply to Neil Deakin from comment #2) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa4a010a70ab With this build, should not lose focus on the first option when hover over the second option. See https://dl.dropboxusercontent.com/u/95157096/85f61cf7/y2lxtpaogs.mp4
|
|
Assignee | |
Comment 5•8 years ago
|
||
That's the correct behaviour.
|
|
Assignee | |
Comment 6•8 years ago
|
||
Comment on attachment 8798040 [details] [diff] [review] Add styles for disabled menuitems in menulists This isn't quite right for keyboard usage though so let me fix this.
Attachment #8798040 -
Flags: review?(dao+bmo)
(In reply to Neil Deakin from comment #5) > That's the correct behaviour. With non-e10s mode this does not happen.
|
|
Assignee | |
Comment 8•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1e271d5a351
|
|
Assignee | |
Comment 9•8 years ago
|
||
I took a more detailed look at how menulists behave on Windows, and it looks like a native WPF combobox does in fact skip over disabled items, which is different than regular menus and the way IE11 behave. So this patch changes to use that behaviour, similar to non-e10s selects, but should leave menus as is, and the behaviour on non-Windows unchanged.
|
|
Assignee | |
Comment 10•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d04cd63d4120
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8798847 -
Flags: review?(ksteuber)
|
||
Comment 11•8 years ago
|
||
Comment on attachment 8798847 [details] [diff] [review] Skip disabled menuitems Review of attachment 8798847 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #8798847 -
Flags: review?(ksteuber) → review+
|
|
Assignee | |
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7a5e02ed8f48197c6d0cdfee5122d472321d8c3 Bug 1305362, skip disabled menuitems in menulists on all platforms, r=ksteuber
|
||
Comment 13•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c7a5e02ed8f4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•