1305364 - Add latest releases to https://www.mozilla.org/en-US/thunderbird/releases/ release notes list

Status: VERIFIED FIXED

(Release Engineering :: Applications: Shipit, defect)

Description

[Ton [:Tonnes]]

https://www.mozilla.org/en-US/thunderbird/releases/ 

This page listing all Thunderbird releases shows 31 as most recent version.

Instead, it should include the most recent versions (38, 45, etc.)

Comment 1

[Wayne Mery (:wsmwk)]

https://www.mozilla.org/en-US/thunderbird/releases/ 
Oddly enough, it is not linked from https://www.mozilla.org/en-US/thunderbird/ 

Which raises the issue that https://www.mozilla.org/en-US/thunderbird/ "Releases" link points to https://www.mozilla.org/en-US/thunderbird/channel/ which lists only to Beta and Earlybird.  The corresponding Firefox page cycles   
(But now that firefox has redesigned all their web pages, https://www.mozilla.org/en-US/firefox/products/ (once you find it) doesn't have a link to https://www.mozilla.org/en-US/thunderbird/channel/ - and not linked from anywhere as far as I can find)

It seems a bit odd to me

Comment 2

[Kohei Yoshino [:kohei]]

Looks like the recent releases are not in the history: https://product-details.mozilla.org/1.0/thunderbird.json

Does anyone have access to the Ship-It system to fix it?

Comment 3

[Wayne Mery (:wsmwk)]

Thanks kohei. 

Perhaps related to bug 1201286?

Comment 4

[Kohei Yoshino [:kohei]]

Er, no, Bug 1201286 has already been solved. There should be a form for the product history in Ship-It. Sylvestre: can you please take a look at this?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

in https://product-details.mozilla.org/1.0/thunderbird.json
I see all of them:
thunderbird-38.6.0
thunderbird-45.3.0

This is at the end of the file.

Comment 6

[Kohei Yoshino [:kohei]]

I guess the "thunderbird" prefix is not necessary, and various builds are still missing, including 45.0 and 45.1.0.

Comment 7

[Rail Aliiev [:rail]]

Wayne, can you go through the missing releases and mark them as shipped in Ship-it? Please also make sure you specify the date.

Comment 8

[Wayne Mery (:wsmwk)]

Thanks for the note. I had checked a week or two ago. All "recent" releases are already marked shipped.

I've just gone through 2017 and part of 2016. I marked shipped the items below. All others were already marked shipped unless otherwise noted

45 series
Thunderbird-45.1.1-build1 2016/05/31 per https://www.mozilla.org/en-US/thunderbird/45.1.1/releasenotes/
Thunderbird-45.1.0-build3 2016/05/10 per https://www.mozilla.org/en-US/thunderbird/45.1.0/releasenotes/
Thunderbird-45.0-build1 2016/04/12 per https://www.mozilla.org/en-US/thunderbird/45.0/releasenotes/
b1, b3, b4 are all marked shipped already.
I'll check about b2 later (but not relevant to this bug anyway)

38 series
Thunderbird-38.8.0-build1 2016/05/04 per https://www.mozilla.org/en-US/thunderbird/38.8.0/releasenotes/
Thunderbird-38.7.2-build1 2016/04/04 per https://www.mozilla.org/en-US/thunderbird/38.7.2/releasenotes/
38.4.0 through 38.7.1 are marked as shipped. 
earlier builds must still be checked

31 series
most are NOT marked shipped

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to Kohei Yoshino [:kohei] from comment #2)
> Looks like the recent releases are not in the history:
> https://product-details.mozilla.org/1.0/thunderbird.json
> 
> Does anyone have access to the Ship-It system to fix it?
I'm taking this piece. 

Kohei, https://www.mozilla.org/en-US/thunderbird/releases/ is not listing ANY 38.* or 45.*, yet many ARE marked shipped in https://product-details.mozilla.org/1.0/thunderbird.json

Comment 10

[Wayne Mery (:wsmwk)]

All of version 45.x is now at https://www.mozilla.org/en-US/thunderbird/releases/

All of version 38.x are missing. Is it missing because we did not release a "38.0"??  
https://product-details.mozilla.org/1.0/thunderbird.json starts with "38.0.1".

Comment 11

[Ton [:Tonnes]]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #10)
> All of version 45.x is now at
> https://www.mozilla.org/en-US/thunderbird/releases/
> 
> All of version 38.x are missing. Is it missing because we did not release a
> "38.0"??  
> https://product-details.mozilla.org/1.0/thunderbird.json starts with
> "38.0.1".

Good to see the 45.x notes. Regardless of 38.0 or 38.0.1, I think all 38 releases should be included.

Also see https://en.wikipedia.org/wiki/History_of_Mozilla_Thunderbird.

Comment 12

[Wayne Mery (:wsmwk)]

I updated a few 31.x items. And I seem some anomolies where these show as "started" in the summary, but when I go to edit the "shipped" checkbox is marked, and a ship date is already provided!  I resubmitted these
Thunderbird-31.5.0-build1
Thunderbird-31.1.1-build1
Thunderbird-31.0-build1
Thunderbird-38.2.0-build1
Thunderbird-38.0.1-build1

All of 38.x shows shipped except the following, which I have just marked shipped
38.5.0
38.3.0

Comment 13

[Wayne Mery (:wsmwk)]

And I see zero entries for 38.* in https://www.mozilla.org/en-US/thunderbird/releases/

Comment 14

[Kohei Yoshino [:kohei]]

Because 38.0(.1) is not marked as a major release?
https://product-details.mozilla.org/1.0/thunderbird_history_major_releases.json

Comment 15

[Wayne Mery (:wsmwk)]

(In reply to Kohei Yoshino [:kohei] from comment #14)
> Because 38.0(.1) is not marked as a major release?
> https://product-details.mozilla.org/1.0/thunderbird_history_major_releases.
> json

Perhaps. I don't know how to make that happen.  
rehecked Thunderbird-38.0.1-build1 ... it is marked shipped

Comment 16

[Wayne Mery (:wsmwk)]

38.0 (never shipped. Perhaps that's why there's nothing in https://product-details.mozilla.org/1.0/thunderbird_history_major_releases.json  How do we fix that?

The first 38.x to ship out was 38.0.1

Note also https://product-details.mozilla.org/1.0/thunderbird.json has two entries for 38.1.0, even though only one shipped. Ship-it has
shipped	Thunderbird-38.1.0-build1 Update [e-mail]	2015/07/07 3:21	releases/comm-esr38	b32d199c886c
Started	Thunderbird-38.1.0esr-build1 Update [e-mail] 2015/07/06 15:25 releases/comm-esr38	b32d199c886c

Comment 17

[Rail Aliiev [:rail]]

Looks like https://github.com/mozilla-releng/ship-it/blob/0cac23ab2bf379828b567ef769c2771ca2b287ec/kickoff/jsonexport.py#L272 uses https://github.com/mozilla-releng/ship-it/blob/0cac23ab2bf379828b567ef769c2771ca2b287ec/kickoff/jsonexport.py#L37 to identify "major" releases.

38.0.1 doesn't match that regexp.

I created https://github.com/mozilla-releng/ship-it/pull/135 to add a special case for it.

Comment 18

[Rail Aliiev [:rail]]

Attachment: PR

Comment 19

[Johan Lorenzo [:jlorenzo] - PTO - Back August 24th]

Comment on attachment 8813345 [details] [review]
PR

LGTM modulo a test modification. More details at: https://github.com/mozilla-releng/ship-it/pull/135#pullrequestreview-9994458

Comment 20

[Wayne Mery (:wsmwk)]

We still need this to land in production?

Comment 21

[Rail Aliiev [:rail]]

Not yet, this patch needs some love (more tests, maybe a different approach). I may look at this this/next week.

Comment 22

[Jordan Lund (:jlund)]

I'm going to finish this work as I'm currently on releaseduty this rotation. Rail raised this with me today.

Comment 23

[Rail Aliiev [:rail]]

https://github.com/mozilla-releng/ship-it/commit/c97d209e898522018a6588ab159c4a58e8933b40 should fix this. Let's wait until the website is refreshed.

Comment 24

[Rail Aliiev [:rail]]

https://github.com/mozilla/product-details-json/commit/00412610f0b46f6b2e7d3aa5de29b82770e417eb#diff-8f3c3bc56cfcdc0fd8c6f3d33667fffbR1 lgtm, still waiting.

Comment 25

[Rail Aliiev [:rail]]

All good at https://www.mozilla.org/en-US/thunderbird/releases/! \o/

Comment 26

[Wayne Mery (:wsmwk)]

Looks great. thanks!