Closed Bug 1305444 Opened 3 years ago Closed 3 years ago

Misc session restore improvements

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(3 files)

I wrote a few precursor patches while hacking on bug 1304389...
Comment on attachment 8794875 [details]
Bug 1305444 - Add test for dispatched method throwing an error;

https://reviewboard.mozilla.org/r/81126/#review79936
Attachment #8794875 - Flags: review?(dteller) → review+
Comment on attachment 8794873 [details]
Bug 1305444 - Move telemetry assignment, remove variable use;

https://reviewboard.mozilla.org/r/81122/#review79940

Ok.
Attachment #8794873 - Flags: review?(dteller) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ef08ec39cd7
Move telemetry assignment, remove variable use; r=Yoric
https://hg.mozilla.org/integration/autoland/rev/87ebfcabb99a
Remove run_test(); r=Yoric
https://hg.mozilla.org/integration/autoland/rev/a75885a39701
Add test for dispatched method throwing an error; r=Yoric
https://hg.mozilla.org/mozilla-central/rev/87ebfcabb99a
https://hg.mozilla.org/mozilla-central/rev/a75885a39701
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
 19:46:56     INFO -  console.error:
 19:46:56     INFO -    Could not write session state file
 19:46:56     INFO -    Message: ReferenceError: FX_SESSION_RESTORE_WRITE_FILE_MS is not defined
 19:46:56 INFO - Stack:

wat?! What kind of wonky JS scoping problem is this?

Anyway, I don't really care enough to look into this.
Actually, you made a typo.

It should have been `telemetry.FX_SESSION_RESTORE_WRITE_FILE_MS`. Same thing on the next line.
Status: RESOLVED → REOPENED
Flags: needinfo?(gps)
Resolution: FIXED → ---
Gah - too much Python. I forgot that JS allows you to store Object keys without quoting them. In Python, that would be a reference to an undefined variable. I'll re-land with the trivial fix once I've verified tests pass locally.
Flags: needinfo?(gps)
Yeah, one of the reasons for which I'm pushing for static analysis in JS. We have a plan, I just wonder how long it will take us to get there.
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14b09d732f6d
Move telemetry assignment, remove variable use; r=Yoric
https://hg.mozilla.org/mozilla-central/rev/14b09d732f6d
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.