1305498 - Refactor notification code to be more concise

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Our notification code is kind of a mess and unnecessarily complex.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 1. Remove NotificationClient task queue (v1)

Not sure why we needed a task queue for NotificationClient actions. The
actions all go through IPC and are non-blocking, so it's perfectly fine
to perform them off of whatever thread we're on.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Integrate NotificationHandler et al into NotificationCllient (v1)

There's no reason to have NotificationHandler, AppNotificationClient,
and ServiceNotificationClient all separate from the base
NotificationClient class. This patch adds the functionality of
those three classes to NotificationClient.

The notifications hash map is changed from a ConcurrentHashMap to a
regular HashMap with synchronization because I think the use case here
doesn't warrant the added performance and overhead of ConcurrentHashMap.

NotificationService is changed to match the new NotificationClient. Now
the only job for NotificationService is to set a notification as
foreground, rather than to manage all notifications like before.

NotificationHandler, AppNotificationClient, and
ServiceNotificationClient will be removed in a later patch.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 3. Set NotificationListener in GeckoApplication (v1)

Set NotificationListener once in GeckoApplication.onCreate, instead of
spreading it out in GeckoApp, BrowserApp, and GeckoService. This is
possible because there's no longer a distinction between
AppNotificationClient and ServiceNotificationClient in the new,
consolidated NotificationClient.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 4. Remove obsolete notification classes (v1)

Remove AppNotificationClient, ServiceNotificationClient, and
NotificationHandler, now that they've all been replaced by the new,
consolidated NotificationClient.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 5. Use NotificationReceiver for web notification callbacks (v1)

Previously, web notification callbacks went to GeckoApp directly, but
that presented some problems such as not being able to implement the
on-close callback, because we don't want to launch GeckoApp when the
notification is closed by swiping. This patch makes us use
NotificationReceiver for callbacks, and let NotificationReceiver launch
GeckoApp if necessary.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 6. Don't keep notification cookie in native code (v1)

Keep the notification cookie a single location (in the notification
intent itself), and simplify the native notification handling code.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8794972 [details] [diff] [review]
6. Don't keep notification cookie in native code (v1)

Review of attachment 8794972 [details] [diff] [review]:
-----------------------------------------------------------------

Great patches!

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Integrate NotificationHandler et al into NotificationCllient (v1.1)

Updated patch that manually calls the delete intent on a notification when
canceling it, because Android doesn't call it for us.

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 7. Use NotificationReceiver for persistent notifications (v1)

One last patch... Currently, persistent notification callbacks go through a
different code path, but it'd be more consistent and correct to let persistent
notification callbacks go through NotificationReceiver as well.

This takes care of some housekeeping work that was missing for
persistent notifications, such as deleting the mNotifications entry when
the notification is closed.

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Integrate NotificationHandler et al into NotificationCllient (v1.2)

Updated patch that no longer sends the delete intent when we update an existing
notification, because the delete intent may end up affecting the new notification.

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 5. Use NotificationReceiver for web notification callbacks (v1.1)

Updated patch that removes the NotificationClient.mNotifications association
when a NotfiicationHelper notification closes.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/7810eb621144
Refactor notification code to be more concise; r=sebastian

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7810eb621144