1305507 - Can't use Ctrl+Enter to immediately submit a failure classification when pasting a bug number

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

It used to be that you could paste the bug number into the field and hit Ctrl+Enter to save the classification on a failure. However, a recent change landed that causes an error to occur when doing so. If you hit Enter first to make the bug entry field non-active, Ctrl+Enter then works fine.

Comment 1

[Phil Ringnalda (:philor)]

Not all that recent, April.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:1305507 > mozilla:master

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8794980 [details] [review]
[treeherder] KWierso:1305507 > mozilla:master

Not totally tested, but it should let you do a Ctrl-enter while the bug field is in edit mode like it used to.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Phil Ringnalda (:philor) from comment #1)
> Not all that recent, April.

I think bug 1302545 was the more recent change that caused this particular issue.

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8794980 [details] [review]
[treeherder] KWierso:1305507 > mozilla:master

One comment in the PR, but feel free to merge if it still looks right to you.  :)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3092f0b3db1cee03776e6b71f37cab9ebb2b99f7
Bug 1305507 - Save whatever's typed into the bug field before seeing if we can save the classification (#1875) r=camd

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/759d2fa3adb0a904cc635d09cc4d5bbdd172e56d
Revert "Bug 1305507 - Save whatever's typed into the bug field before seeing if we can save the classification (#1875) r=camd"

This reverts commit 3092f0b3db1cee03776e6b71f37cab9ebb2b99f7.

Comment 8

[Cameron Dawson [:camd]]

Hey Wes: I had to revert this.  It prevents you from manually entering a bug number in that field.  I didn't catch it in the review.  So perhaps we can come up with a better way to do this.  Like having the ctrl+enter call a function that does that saveEnteredBugNumber first.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: PR 1883

This doesn't change state in the state check and should hopefully do the job better.

Comment 10

[Cameron Dawson [:camd]]

Comment on attachment 8796308 [details] [review]
PR 1883

I commented in the PR.  I think this one's still not quite right.  Several test paths for it.

Comment 11

[Ed Morley [:emorley]]

Ping for Wes' question here:
https://github.com/mozilla/treeherder/pull/1883#issuecomment-250637149

Comment 12

[Cameron Dawson [:camd]]

Wes-- Dang, sorry I missed the email with this question in it. Yeah, I think you could do that. Looks like this SO response has an idea how to use it?

http://stackoverflow.com/a/18282155/333614

-Cam

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8796308 [details] [review]
PR 1883

Rebased this on to master and added some additional validation. I've tested this as much as I can using web-server.js locally (commenting out the login requirements and trying to submit classifications). I couldn't get your suggestion to work, so I just went with adding additional validation in a few places.

Comment 14

[Cameron Dawson [:camd]]

Comment on attachment 8796308 [details] [review]
PR 1883

Wes--  There were a couple linting errors.  Other than that, this looks good.  Please reassign to me when they're fixed.  :)

Comment 15

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/296ecb19c37debd6d498202ad69e2af707aedd5d
Bug 1305507 - Make sure canSaveClassifications works while entering bug number (#1883) r=camd

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Fixed up the eslint issues and landed it.