clang-cl optimized builds paint lots of black boxes

RESOLVED FIXED in Firefox 52

Status

()

Core
Graphics
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dmajor, Assigned: dmajor)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
The black regions do not appear consistently. Doing things that cause repaint (activating mouseovers, switching tabs, etc.) usually gets the right thing to show up.

Reproduces with this mozconfig:
export CC=clang-cl
export CXX=clang-cl

Does not reproduce with this mozconfig:
ac_add_options --disable-optimize
export CC=clang-cl
export CXX=clang-cl
(Assignee)

Comment 1

a year ago
Created attachment 8795024 [details]
screenshot of black regions
(Assignee)

Comment 2

a year ago
Does reproduce with e10s off
Does NOT reproduce with layers.acceleration.disabled
(Assignee)

Comment 3

a year ago
Does not reproduce with layers.prefer-d3d9
(Assignee)

Comment 4

a year ago
Does not reproduce with gfx.direct2d.disabled
(Disabling D3D11 as in comment 3 also disables D2D, so that makes sense)
(Assignee)

Comment 5

a year ago
DrawTargetD2D1::ClearRect was getting uninitialized values of isPixelAligned from GetDeviceSpaceClipRect.
Assignee: nobody → dmajor
(Assignee)

Comment 6

a year ago
Created attachment 8795558 [details] [diff] [review]
Initialize aIsPixelAligned
Attachment #8795558 - Flags: review?(jmuizelaar)
Attachment #8795558 - Flags: review?(jmuizelaar) → review?(bas)
Comment on attachment 8795558 [details] [diff] [review]
Initialize aIsPixelAligned

Review of attachment 8795558 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.
Attachment #8795558 - Flags: review?(bas) → review+

Comment 8

a year ago
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7a71d3ddcc6
Initialize the out-param of DrawTargetD2D1::GetDeviceSpaceClipRect. r=Bas

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d7a71d3ddcc6
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.