Attachment #8795060 - Flags: review?(gfritzsche) → review?(alessio.placitelli)
Oops, I forgot that I have a patch for the ActorsParent.cpp issue already posted in Bug 1304779. It's already gotten r+, so marking this bug as dependent on that one. Sorry!
Depends on: 1304779
Comment on attachment 8795060 [details] Bug 1305577 - Remove the unused function KeyedScalar::SetMaximum https://reviewboard.mozilla.org/r/81246/#review79896 Good catch, GCC (and thanks for the patch, Sylvestre!). As pointed in the comment below, we should not remove that function, but rather fix the bug that was lurking behind it. This gave us one more reason to push forward with the C++ test coverage for the Telemetry APIs (starting from bug 1305648). ::: toolkit/components/telemetry/TelemetryScalar.cpp (Diff revision 1) > > return scalar->AddValue(aValue); > } > > -void > -KeyedScalar::SetMaximum(const nsAString& aKey, uint32_t aValue) This is actually pointing to a real bug. Instead of removing this function, we should change the *SetValue*s highlighted [here](https://dxr.mozilla.org/mozilla-central/rev/c55bcb7c777ea09431b4d16903ed079ae5632648/toolkit/components/telemetry/TelemetryScalar.cpp#1700,1721) to *SetMaximum*.
Attachment #8795060 - Flags: review?(alessio.placitelli) → review-
(In reply to Alessio Placitelli [:Dexter] from comment #4) > Comment on attachment 8795060 [details] > > This is actually pointing to a real bug. Instead of removing this function, > we should change the *SetValue*s highlighted > [here](https://dxr.mozilla.org/mozilla-central/rev/ > c55bcb7c777ea09431b4d16903ed079ae5632648/toolkit/components/telemetry/ > TelemetryScalar.cpp#1700,1721) to *SetMaximum*. Fixing this in bug 1305654.
Has been fixed by the various stakeholders.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
Attachment #8795060 - Attachment is obsolete: true
Attachment #8795061 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.