1305615 - "Cannot open SQLite connection" while running unittests

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[:Grisha Kruglov]

This is a follow up bug, stemming from Bug 1302601. Once regressions in the testsuite were fixed, we are still left with SQL connection errors popping up around some tests - TestLegacyLoader, VisitsHelperTest, TabsProvider tests, and tests extending BrowserProviderHistoryVisitsTestBase.

Comment 1

[:Grisha Kruglov]

Attachment: Bug 1305615 - Use correct database in tests, and close db connection in TestLegacyLoader

We need to ensure we can explicitely close any database connections we open in the TestLegacyLoader,
so we initialize a BrowserProvider instance so that we can then call .shutdown() on it once we're done,
which will close any open connections.

Additionally, we need to make sure to use correct authority when registering (using AUTHORITY_URI produces dual mapping
of providers, from content://org.fennec... and from org.fennec...), and wrap our providers in a DelegatingTestContentProvider,
which will append PARAM_IS_TEST param to wrapped URIs -  when present this ensure we won't try to load a per-profile database.

Review commit: https://reviewboard.mozilla.org/r/81276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81276/

Comment 2

[:Grisha Kruglov]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=76eaadaa78be

Comment 3

[:Grisha Kruglov]

(In reply to :Grisha Kruglov from comment #2)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=76eaadaa78be

These don't seem to actually run in automation at this point. It "works on my machine" both via |mach gradle cleanTest test| and running everything in Android Studio.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

It's there, just hidden by default.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=76eaadaa78be&exclusion_profile=false&group_state=expanded&filter-tier=1&filter-tier=2&filter-tier=3

Comment 5

[:Grisha Kruglov]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> It's there, just hidden by default.
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=76eaadaa78be&exclusion_profile=false&group_state=expan
> ded&filter-tier=1&filter-tier=2&filter-tier=3

Ah, thank you! Well then, it's all green there as well.

Comment 6

[Andrzej Hunt :ahunt]

Comment on attachment 8795142 [details]
Bug 1305615 - Use correct database in tests, and close db connection in TestLegacyLoader

https://reviewboard.mozilla.org/r/81276/#review80048

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b79b95e1f3b
Use correct database in tests, and close db connection in TestLegacyLoader r=ahunt

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e1501ff97cdb

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1b79b95e1f3b