"Cannot open SQLite connection" while running unittests

RESOLVED FIXED in Firefox 51

Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Grisha, Assigned: Grisha)

Tracking

unspecified
Firefox 52
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox51 fixed, firefox52 fixed)

Details

(Whiteboard: [MobileAS])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This is a follow up bug, stemming from Bug 1302601. Once regressions in the testsuite were fixed, we are still left with SQL connection errors popping up around some tests - TestLegacyLoader, VisitsHelperTest, TabsProvider tests, and tests extending BrowserProviderHistoryVisitsTestBase.
Comment hidden (mozreview-request)
(Assignee)

Comment 3

2 years ago
(In reply to :Grisha Kruglov from comment #2)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=76eaadaa78be

These don't seem to actually run in automation at this point. It "works on my machine" both via |mach gradle cleanTest test| and running everything in Android Studio.
Blocks: 1302601
Blocks: 1302602
No longer blocks: 1302601
status-firefox51: --- → affected
status-firefox52: --- → affected
Depends on: 1302601
(Assignee)

Comment 5

2 years ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> It's there, just hidden by default.
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=76eaadaa78be&exclusion_profile=false&group_state=expan
> ded&filter-tier=1&filter-tier=2&filter-tier=3

Ah, thank you! Well then, it's all green there as well.

Comment 6

2 years ago
mozreview-review
Comment on attachment 8795142 [details]
Bug 1305615 - Use correct database in tests, and close db connection in TestLegacyLoader

https://reviewboard.mozilla.org/r/81276/#review80048
Attachment #8795142 - Flags: review?(ahunt) → review+

Comment 7

2 years ago
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b79b95e1f3b
Use correct database in tests, and close db connection in TestLegacyLoader r=ahunt

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/e1501ff97cdb
status-firefox51: affected → fixed
Flags: in-testsuite+

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1b79b95e1f3b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Updated

2 years ago
Iteration: --- → 1.5
You need to log in before you can comment on or make changes to this bug.