Closed Bug 1305652 Opened 8 years ago Closed 7 years ago

Since Firefox 49, template with id and pwd not filled with add-on "KDE Wallet password integration"

Categories

(Firefox :: Extension Compatibility, defect)

Product:
Firefox
Component:
Extension Compatibility
Version:
49 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: epistemepromeneur, Unassigned)

References

Details

Attachments

(1 file)

searchLogins() function modified in KDE5WalletStorage.js
1.43 KB, text/plain
Details 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160923000000

Steps to reproduce:

go to any site as www.edf.fr, www.amazon.fr, bugzilla.mozilla.org etc.
then
login
wait for firefox fills the id and pwd fields
nothing happens
you must manually fill the fields

i use kwallet extension

also if i delete in kwallet the record about the site then FF does not ask for me if i want to record id and pwd



Expected results:

fields must be filled by FF
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
same problem in safe mode
i forgot to mention: opensuse 13.1 x86_64

same problem with opensuse 42.1 x86_64
Does it work with a clean profile?
https://support.mozilla.org/fr/kb/utiliser-gestionnaire-profils-creer-supprimer-profils
Component: Untriaged → Password Manager
Flags: needinfo?(epistemepromeneur)
Product: Firefox → Toolkit
no problem with a clean profile.

i assume it is again a compatibility problem with kde kwallet 2.4.1 for kde 4.x in opensuse 13.1

each time FF changes something about pwd there is a compatibility problem with the very usefull kwallet!

also i assume there is a problem with kde5 kwalett 1.1 used in kde plasma 5 environment in opensuse 42.1

it's similar (not same) to this bug ?
https://bugzilla.mozilla.org/show_bug.cgi?id=961005

anyway we must warn "guille" the dev of kwallet. he has an account at bugzilla.mozilla.org
Flags: needinfo?(epistemepromeneur)
I think you mean this add-on:
https://addons.mozilla.org/fr/firefox/addon/kde5-wallet-password-integrati/
Component: Password Manager → Extension Compatibility
Product: Toolkit → Firefox
There is an old extension too (https://addons.mozilla.org/fr/firefox/addon/kde-wallet-password-integratio/) but probably outdated (October 2014).
@loic 

yes there is a problem with these 2 extensions

i warned guille here
https://www.linux-apps.com/default/hive/show/content/116886
i think it is linked to a new feature of FF:
FF can use http id,pwd for https connection. no need to record a new record for https connection. If i well understand.
Summary: 49.0.1, since update ff does not fill template with id and pwd → Since Firefox 49, template with id and pwd not filled with add-on "KDE Wallet password integration"
i install again 48.0.1 then no more problem. i can't wait a fix.
the new feature about login manager and in relation with pwd manager and i assume the bug:

https://www.mozilla.org/en-US/firefox/49.0/releasenotes/

Updated Firefox Login Manager to allow HTTPS pages to use saved HTTP logins. It’s one more way Firefox is supporting Let’s Encrypt and helping users transition to a more secure web.
If you want, you can download the tool Mozregression to find a regression range in FF48.
http://mozilla.github.io/mozregression/

You can create a testing profile with KDE Wallet add-on installed and use it with mozregression with the command: mozregression --good=48 --profile=path_to_profile
...
Was this inbound build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): bad
27:56.31 INFO: Narrowed inbound regression window from [1c6385ae, d65b4865] (3 revisions) to [1c6385ae, 690226a9] (2 revisions) (~1 steps left)
27:56.31 INFO: Oh noes, no (more) inbound revisions :(
27:56.31 INFO: Last good revision: 1c6385ae1fe7e37d8f23f958ce14582f07af729e
27:56.31 INFO: First bad revision: 690226a9fb27054d8a20fc7625a2ebd7067573ce
27:56.31 INFO: Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=1c6385ae1fe7e37d8f23f958ce14582f07af729e&tochange=690226a9fb27054d8a20fc7625a2ebd7067573ce
x@linux-b4lz:~>
Are you sure about the regression range? I don't see any bugfix related to the pwd manager in this pushlog.
(In reply to Loic from comment #13)
> Are you sure about the regression range? I don't see any bugfix related to
> the pwd manager in this pushlog.

i will retry

another way to know where the problem begins:
the first message in linux-apps is about 49
then
there is mine about 49.0.1
...
Was this inbound build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): bad
28:06.79 INFO: Narrowed inbound regression window from [c57a0e71, 1cafe268] (3 revisions) to [c57a0e71, f59918cf] (2 revisions) (~1 steps left)
28:06.79 INFO: Oh noes, no (more) inbound revisions :(
28:06.79 INFO: Last good revision: c57a0e71e7cdf62ba3d443e250e6086368ad0833
28:06.79 INFO: First bad revision: f59918cf04fa5954101b0274ebf60fb7e11e7a21
28:06.79 INFO: Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c57a0e71e7cdf62ba3d443e250e6086368ad0833&tochange=f59918cf04fa5954101b0274ebf60fb7e11e7a21

x@linux-b4lz:~>
victory
The add-on dev needs to update his add-on probably. Did you contact him?

:mattn, do you know if your patches may affect password manager add-on?
Blocks: 667233
Flags: needinfo?(MattN+bmo)
as i said in my comment #4

""guille" the dev of kwallet. he has an account at bugzilla.mozilla.org"

it would be convincing  if a firefox dev contacts him.
you can find the address of guille here
https://bugzilla.mozilla.org/show_bug.cgi?id=961005

guille@losmolina.com.ar
I'm not a developper, but I've corrected myself the file KDE5WalletStorage.js.

It looks like the patch in the version 1.2, but it avoids the crashes caused when one of the 3 vars is is "undefined".
Attachment #8801859 - Attachment mime type: text/plain → application/javascript
Attachment #8801859 - Attachment mime type: application/javascript → text/plain
Hello, does anyone know how to test an unsigned extension?, without that I am forced to submit untested extensions to Mozilla in order to test it.
I am updating the new version of the extension with Beguam changes to KDE5WalletStorage.js
(In reply to Guille from comment #21)
> Hello, does anyone know how to test an unsigned extension?, without that I
> am forced to submit untested extensions to Mozilla in order to test it.

Maybe it's not the good method, but I simply edit or replace files in ~/.mozilla/firefox/xxx.xxx/extensions/kde5wallet@guillermo.molina/
(In reply to Guille from comment #21)
> Hello, does anyone know how to test an unsigned extension?

There are various options described here: https://wiki.mozilla.org/Addons/Extension_Signing
@guille

there is an update for kde5, the 1.3 version.

can we expect a new kde4 version which fixes the problem?

thanks
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(MattN+bmo)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: