1305679 - Fix CID 1373350: Uninitialized members (UNINIT_CTOR) in VideoDecoderChild

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[James Cheng[:JamesCheng]]

*** CID 1373350:  Uninitialized members  (UNINIT_CTOR)
/dom/media/ipc/VideoDecoderChild.cpp: 26 in mozilla::dom::VideoDecoderChild::VideoDecoderChild()()
20     using namespace gfx;
21
22     VideoDecoderChild::VideoDecoderChild()
23       : mThread(VideoDecoderManagerChild::GetManagerThread())
24       , mCanSend(true)
25     {
>>>     CID 1373350:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mLayersBackend" is not initialized in this constructor nor in any functions that it calls.
26     }


initial value could be aligned with 
http://searchfox.org/mozilla-central/rev/05ed82e50b45df5aa5a8fad219dece1b56757261/dom/media/MediaFormatReader.h#32

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1305679 - Fix CID 1373350: Uninitialized members (UNINIT_CTOR) in VideoDecoderChild

Review commit: https://reviewboard.mozilla.org/r/81362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81362/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8795239 [details]
Bug 1305679 - Fix CID 1373350: Uninitialized members (UNINIT_CTOR) in VideoDecoderChild

https://reviewboard.mozilla.org/r/81362/#review79920

My guess is that it is probably a false positive, because InitIPDL() (which sets mLayersBackend) should always be called before Init() (which has the only use of mLayersBackend).
So I will defer to the original author to decide whether we should ignore or "fix" this warning.

Comment 3

[James Cheng[:JamesCheng]]

I know that InitIPDL will do the init but is it worth fixing it since initializing data member is reasonable in constructor?

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8795239 [details]
Bug 1305679 - Fix CID 1373350: Uninitialized members (UNINIT_CTOR) in VideoDecoderChild

Though I'm usually happy with cheap inits when it removes doubts over potential uninitialized uses, I'll let Matt decide, as it's his code.

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8795239 [details]
Bug 1305679 - Fix CID 1373350: Uninitialized members (UNINIT_CTOR) in VideoDecoderChild

https://reviewboard.mozilla.org/r/81362/#review80060

Yeah, no harm in doing this.

Comment 6

[James Cheng[:JamesCheng]]

Thank you!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8837c195fbc6
Fix CID 1373350: Uninitialized members (UNINIT_CTOR) in VideoDecoderChild r=mattwoodrow

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8837c195fbc6