./mach test --debugger=<debugger> doesn't fail if <debugger> isn't available

RESOLVED FIXED in Firefox 64

Status

defect
P1
normal
RESOLVED FIXED
3 years ago
6 months ago

People

(Reporter: chutten, Assigned: egao)

Tracking

49 Branch
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

3 years ago
I successfully reproduced a difficult intermittent with

./mach test --debugger=rr <the test>

It was only when I ran `rr replay` that the shell informed me that rr wasn't installed.

It has now been days of trying (in vain) to reproduce it with rr actually attached :(

Maybe ./mach test should error out if `which <debugger>` can't come up with anything? (in an appropriately-cross-platform way)
Component: mach → General
Product: Core → Testing
We have the Python `which` module available in-tree, we can use that. (Also: if you're not running rr with chaos mode, you should try that!)
Reporter

Comment 2

3 years ago
--debugger-args="record -h" bien sur.

...though all I've managed to do is reproduce _other_ intermittents and find tests that just break if you invalidate their flakey timeouts in that way. ...so not best pleased just yet.
Assignee

Comment 3

9 months ago
- added checkers in python/mach/mach/main.py prior to calling registrar.py.
- added internal function to check if specified debugger is installed.
- support both ./mach test <test_name> and ./mach <test_category> styles.
Comment on attachment 9013037 [details]
Bug 1305695 - ./mach test --debugger=<debugger> doesn't fail if <debugger> isn't available r?gbrown

Geoff Brown [:gbrown] has approved the revision.
Attachment #9013037 - Flags: review+

Comment 6

9 months ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/05df95ba3a98
/mach test --debugger=<debugger> doesn't fail if <debugger> isn't available r=gbrown

Comment 7

9 months ago
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34efa9f14353
Backed out changeset 05df95ba3a98 for ES lint failures CLOSED TREE
Strange...

https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=0d3748a0ad24606a4debc37726b0743ab4676734&selectedJob=202714104

https://queue.taskcluster.net/v1/task/HKXEwMEaSp-ExFV6sNbS-A/runs/0/artifacts/public/logs/live_backing.log

[task 2018-10-01T20:52:26.393Z] + cd /builds/worker/checkouts/gecko/
[task 2018-10-01T20:52:26.393Z] + cp -r /build/node_modules_eslint node_modules
[task 2018-10-01T20:52:28.056Z] + ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules
[task 2018-10-01T20:52:28.058Z] + ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules
[task 2018-10-01T20:52:28.059Z] + ./mach lint -l eslint -f treeherder --quiet
[task 2018-10-01T20:52:28.654Z] Specified debugger '{}' is not found.
[task 2018-10-01T20:52:28.654Z] Is it installed? Is it in your PATH?
[taskcluster 2018-10-01 20:52:29.444Z] === Task Finished ===
Assignee: nobody → egao
Priority: -- → P1

Comment 9

9 months ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce1bae1b9226
/mach test --debugger=<debugger> doesn't fail if <debugger> isn't available r=gbrown

Comment 10

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ce1bae1b9226
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.