Closed Bug 1305695 Opened 5 years ago Closed 3 years ago

./mach test --debugger=<debugger> doesn't fail if <debugger> isn't available


(Testing :: General, defect, P1)

49 Branch


(firefox64 fixed)

Tracking Status
firefox64 --- fixed


(Reporter: chutten, Assigned: egao)




(1 file)

I successfully reproduced a difficult intermittent with

./mach test --debugger=rr <the test>

It was only when I ran `rr replay` that the shell informed me that rr wasn't installed.

It has now been days of trying (in vain) to reproduce it with rr actually attached :(

Maybe ./mach test should error out if `which <debugger>` can't come up with anything? (in an appropriately-cross-platform way)
Component: mach → General
Product: Core → Testing
We have the Python `which` module available in-tree, we can use that. (Also: if you're not running rr with chaos mode, you should try that!)
--debugger-args="record -h" bien sur.

...though all I've managed to do is reproduce _other_ intermittents and find tests that just break if you invalidate their flakey timeouts in that way. not best pleased just yet.
- added checkers in python/mach/mach/ prior to calling
- added internal function to check if specified debugger is installed.
- support both ./mach test <test_name> and ./mach <test_category> styles.
Comment on attachment 9013037 [details]
Bug 1305695 - ./mach test --debugger=<debugger> doesn't fail if <debugger> isn't available r?gbrown

Geoff Brown [:gbrown] has approved the revision.
Attachment #9013037 - Flags: review+
Pushed by
/mach test --debugger=<debugger> doesn't fail if <debugger> isn't available r=gbrown
Backout by
Backed out changeset 05df95ba3a98 for ES lint failures CLOSED TREE

[task 2018-10-01T20:52:26.393Z] + cd /builds/worker/checkouts/gecko/
[task 2018-10-01T20:52:26.393Z] + cp -r /build/node_modules_eslint node_modules
[task 2018-10-01T20:52:28.056Z] + ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules
[task 2018-10-01T20:52:28.058Z] + ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules
[task 2018-10-01T20:52:28.059Z] + ./mach lint -l eslint -f treeherder --quiet
[task 2018-10-01T20:52:28.654Z] Specified debugger '{}' is not found.
[task 2018-10-01T20:52:28.654Z] Is it installed? Is it in your PATH?
[taskcluster 2018-10-01 20:52:29.444Z] === Task Finished ===
Assignee: nobody → egao
Priority: -- → P1
Pushed by
/mach test --debugger=<debugger> doesn't fail if <debugger> isn't available r=gbrown
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.