Fix --artifact try syntax flag on TaskCluster

RESOLVED FIXED in Firefox 52

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: maja_zf, Assigned: maja_zf)

Tracking

(Blocks 1 bug)

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

In a try push [1], I noticed that the --artifact try syntax was never being checked on certain TC build tasks because they use --skip-buildbot-actions, which means that |is_automation| set to False in the mozharness config. 

Example
> c:\mozilla-build\python\python.exe .\build\src\testing\mozharness\scripts\fx_desktop_build.py --config builds\taskcluster_firefox_win64_opt.py --branch try --skip-buildbot-actions --work-dir z:\task_1473434753\build 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=010de1d900f9815e543050418e51409d6da2ea3f&selectedJob=27217582
Comment hidden (mozreview-request)

Comment 3

3 years ago
mozreview-review
Comment on attachment 8795311 [details]
Bug 1305720 - Check for --artifact try syntax regardless of is_automation value;

https://reviewboard.mozilla.org/r/81408/#review79970
Attachment #8795311 - Flags: review?(armenzg) → review+

Comment 4

3 years ago
Pushed by mjzffr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8a0d7d0adf23
Check for --artifact try syntax regardless of is_automation value; r=armenzg

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8a0d7d0adf23
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.