1305720 - Fix --artifact try syntax flag on TaskCluster

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

In a try push [1], I noticed that the --artifact try syntax was never being checked on certain TC build tasks because they use --skip-buildbot-actions, which means that |is_automation| set to False in the mozharness config. 

Example
> c:\mozilla-build\python\python.exe .\build\src\testing\mozharness\scripts\fx_desktop_build.py --config builds\taskcluster_firefox_win64_opt.py --branch try --skip-buildbot-actions --work-dir z:\task_1473434753\build 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=010de1d900f9815e543050418e51409d6da2ea3f&selectedJob=27217582

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1305720 - Check for --artifact try syntax regardless of is_automation value;

Check try message for --artifact even if fx_desktop_build.py is run with
--skip-buildbot-actions

We can't rely on buildbot config. Add checks to TryToolsMixin._extract_try_message so
that it works even if self.buildbot_config is None.

Review commit: https://reviewboard.mozilla.org/r/81408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81408/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Try push showing that --artifact flag is checked on all platforms:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=25fed05039ea91b9d6ce49fb5e8c19b220661382

Comment 3

[Armen [:armenzg]]

Comment on attachment 8795311 [details]
Bug 1305720 - Check for --artifact try syntax regardless of is_automation value;

https://reviewboard.mozilla.org/r/81408/#review79970

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a0d7d0adf23
Check for --artifact try syntax regardless of is_automation value; r=armenzg

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a0d7d0adf23