Closed Bug 1305755 Opened 8 years ago Closed 8 years ago

Text in category checkbox-list in task dialog is invisible for dark themes

Categories

(Calendar :: Dialogs, defect)

Product:
Calendar
Component:
Dialogs
Version:
Lightning 4.7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dewelooper, Assigned: Paenglab)

Details

Attachments

(2 files)

tb_new_task_dialog.jpg
29.74 KB, image/jpeg
Details
Bug1305755.patch
957 bytes, patch
MakeMyDay
: review+
Fallen
: approval-calendar-aurora+
Fallen
: approval-calendar-beta+
Fallen
: approval-calendar-esr+
Details | Diff | Splinter Review
Attached image tb_new_task_dialog.jpg — 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160923225245

Steps to reproduce:

A1. Run Linux with gnome desktop
A2. Install gtk-theme with dark menu background colour and light menu text colour  like numix-frost for example.

B1. Run TB and open calendar tab.
B2. Open "New Task" dialog to create a new task.
B3. Open category pull-down-list (checkbox-list) to choose a category.


Actual results:

The text of the listed categories in category list is invisible. (see attachment)


Expected results:

The text (listed categories) should be visible in the light colour defined in the theme config.
Summary: text of category checkbox-list invisible (calendar-app -> New Task dialog) → text in category checkbox-list is invisible (calendar-app -> New Task dialog)
Component: Untriaged → General
Product: Thunderbird → Calendar
Version: 49 Branch → unspecified
dewelooper, which version of Thunderbird/Lightning do you use? Are you on 49/5.1?

Jörg, thanks for moving this to calendar. But there's no need to cc me on every bug you tranfer. Calendar bugs are being triaged on a regular basis by several people.
Component: General → Dialogs
Summary: text in category checkbox-list is invisible (calendar-app -> New Task dialog) → Text in category checkbox-list in task dialog is invisible for dark themes
I can reproduce this bug under Thunderbird/Lightning 45.3.0/4.7 and 49.0beta/5.1.

But there is own little difference (referring to numix-frost theme).
In 45.03 the the menu text colour is the same like the menu background colour: grey (see attachment).
In 49.0beta the menu text colour is black.

The menu text colour defined in the theme is white.

Btw. this affects only the category pull-down-list (checkbox-list).
Attached patch Bug1305755.patch — — Splinter Review 
Setting the text color to MenuText fixes the issue. This is needed because only the background color was set. Tested on Linux, OS X and Win10.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8795785 - Flags: review?(makemyday)
Attachment #8795785 - Flags: approval-calendar-esr?(philipp)
Attachment #8795785 - Flags: approval-calendar-beta?(philipp)
Attachment #8795785 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8795785 [details] [diff] [review]
Bug1305755.patch

Review of attachment 8795785 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the quick patch, r=me.
Attachment #8795785 - Flags: review?(makemyday) → review+
Version: unspecified → Lightning 4.7
https://hg.mozilla.org/comm-central/rev/f180e55bfcde
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 5.4
Attachment #8795785 - Flags: approval-calendar-esr?(philipp)
Attachment #8795785 - Flags: approval-calendar-esr+
Attachment #8795785 - Flags: approval-calendar-beta?(philipp)
Attachment #8795785 - Flags: approval-calendar-beta+
Attachment #8795785 - Flags: approval-calendar-aurora?(philipp)
Attachment #8795785 - Flags: approval-calendar-aurora+
Keywords: checkin-needed
Whiteboard: checked-in on c-c
Whiteboard: [update target milestone: 4.7.5]
Target Milestone: 5.2 → 4.7.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: