1305794 - Remove Cortana-related strings from mozilla-central

Status: RESOLVED FIXED

(Firefox :: Search, defect, P4)

Description

[:Felipe Gomes (needinfo for replies!)]

+++ This bug was initially created as a clone of Bug #1287622 +++

Bug 1287622 removed the usage of the strings "redirectWindowsSearch.label" and "redirectWindowsSearch.accesskey", but they weren't removed from the tree.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Filipe, can you fix this?

Comment 2

[u579587]

Hey Jared, what does it mean, removing from the tree?

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Hi Filipe,

here you can see that this label was removed: https://hg.mozilla.org/mozilla-central/rev/fd5453b8f5b8#l4.34

but the string that it refered too is still in the code, but now it's unused: http://searchfox.org/mozilla-central/rev/572e74ee991bbfd812766b4524237eb77577a4b1/browser/locales/en-US/chrome/browser/preferences/search.dtd#16

So you should remove these two strings from the search.dtd file

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Filipe from comment #2)
> Hey Jared, what does it mean, removing from the tree?

"the tree" is just another name for mozilla-central :)

Comment 5

[u579587]

Attachment: 0001-Bug-8791737-Remove-Cortana-related-code-from-Firefox.patch

Comment 6

[u579587]

I've uploaded a new patch that also removes those strings in search.dtd. thanks for the help! :)

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8798044 [details] [diff] [review]
0001-Bug-8791737-Remove-Cortana-related-code-from-Firefox.patch

Thanks for the patch, Filipe. The change you made is correct, but it looks like the patch also included an unrelated change in browser/app/profile/firefox.js.

Could you post a new patch that doesn't include that?

Comment 8

[Thomas Charles]

Attachment: Bug-1305794-Remove-Cortana-related-strings-from-mozilla-central.patch

Comment 9

[Thomas Charles]

Hi,

I am new to this and looking for a simple first bug to fix, to help me get used to process of submitting bug fixes.

I noticed that this has had no activity for over a month and was still open, so I have uploaded a patch. If this patch is ok, can I have this bug assigned to me?

Thanks for any assistance

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff1755fa83c
Remove Cortana-related strings from mozilla-central. r=felipe

Comment 11

[:Felipe Gomes (needinfo for replies!)]

Thanks everyone! I added both of your names in the commit message.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff1755fa83c

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9ff1755fa83c