All users were logged out of Bugzilla on October 13th, 2018

Use fewer files from common.tests.zip in web-platform-tests

ASSIGNED
Assigned to

Status

ASSIGNED
2 years ago
4 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

(Depends on: 2 bugs, Blocks: 1 bug)

Version 3
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(10 attachments)

(Assignee)

Description

2 years ago
Bug 1286900 started using most WPT files from a source checkout (namely tests and meta files). But we still rely on several files from common.tests.zip. This bug is about reducing that dependency, possibly even eliminating it.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 25

2 years ago
chmanchester: you may care about the patch that introduced bin.tests.zip.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 28

2 years ago
Gah - mozinfo.json isn't working right on TC with this series. I'll look into it tomorrow. Buildbot is fine though. https://treeherder.mozilla.org/#/jobs?repo=try&revision=1504587cb39f66d652292934ff078e0cd539c0d3 for the curious.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Blocks: 1305205

Comment 39

2 years ago
mozreview-review
Comment on attachment 8795536 [details]
Bug 1305795 - Produce a bin.tests.zip with binary files;

https://reviewboard.mozilla.org/r/81558/#review80354

::: python/mozbuild/mozbuild/artifacts.py:168
(Diff revision 5)
> +    # TODO reconsider doing this.
> +    # When we introduced test artifact processing, the point was to extract
> +    # bin/* files from common.tests.zip into a smaller zip. Now that we have
> +    # bin.tests.zip, this extract step may not be necessary and we can perform
> +    # any filtering (if we need to do it at all) during archive extraction
> +    # time.

I don't think this comment is adding much. It would apply nearly equally to the packaged build we handle, so implies we should re-write that too. I don't agree with the premise, but if you'd like to discuss this I think it would be better off tracked in a follow up bug.
(Assignee)

Updated

2 years ago
Attachment #8795489 - Flags: review?(ted)
Attachment #8795491 - Flags: review?(ted)
(Assignee)

Updated

2 years ago
Attachment #8795490 - Flags: review?(ted)
(Assignee)

Updated

2 years ago
Depends on: 1306098

Comment 40

2 years ago
mozreview-review
Comment on attachment 8795490 [details]
Bug 1305795 - Set mozinfo_json_url property;

https://reviewboard.mozilla.org/r/81532/#review80602

::: testing/mozharness/mozharness/mozilla/taskcluster_helper.py:205
(Diff revision 3)
> -            p['packageUrl'] if p.get('packageUrl') else None,
> -            p['testPackagesUrl'] if p.get('testPackagesUrl') else None,
> -            p['symbolsUrl'] if p.get('symbolsUrl') else None
> +            p.get('packageUrl') or None,
> +            p.get('testPackagesUrl') or None,
> +            p.get('symbolsUrl') or None,
> +            p.get('mozinfoJsonUrl') or None,

Is the `or None` part even necessary?

Comment 41

2 years ago
mozreview-review
Comment on attachment 8795485 [details]
Bug 1305795 - Stop extracting web-platform directory;

https://reviewboard.mozilla.org/r/81522/#review85088
Attachment #8795485 - Flags: review?(ted) → review+

Comment 42

2 years ago
mozreview-review
Comment on attachment 8795538 [details]
Bug 1305795 - Remove pull action from WPT script;

https://reviewboard.mozilla.org/r/81562/#review85090
Attachment #8795538 - Flags: review?(ted) → review+
You need to log in before you can comment on or make changes to this bug.