1305864 - Assert in conformance2/textures/misc/tex-input-validation.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

ANGLE doesn't like that the source and dest formats for CopyTexSubImage have different component sizes. (RGB5_A1 and RGBA8 respectively)
It's really hard to tell if the spec allows this or not, assuming RGBA8 was originally unsized RGBA.
Effective formats are technically different from sized and unsized formats, though effective formats are always effectively sized.
CopyTexImage specifies which effective format is chosen when an unsized internalformat is used.

Chrome passes this test somehow. Perhaps we always use a sized format when we can?

Comment 1

[Kelsey Gilbert [:jgilbert]]

Sadly, it sounds like we must store the internal format and effective internal format separately:
GLES 3.0.4 p160:
"The internal formats and effective internal formats of the derived mipmap arrays all match those of the
`level_base` array, and the dimensions of the derived arrays follow the requirements described in section 3.8.13."

Comment 4

[Kelsey Gilbert [:jgilbert]]

Passes on OSX.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1305864 - Catch INVALID_OP from bad-format CopyTexSubImage in ANGLE for now. -

Review commit: https://reviewboard.mozilla.org/r/99620/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99620/

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8820096 [details]
Bug 1305864 - Catch INVALID_OP from bad-format CopyTexSubImage in ANGLE for now. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99620/diff/1-2/

Comment 7

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8820096 [details]
Bug 1305864 - Catch INVALID_OP from bad-format CopyTexSubImage in ANGLE for now. -

https://reviewboard.mozilla.org/r/99620/#review100084

LGTM

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a706bd4d28b
Catch INVALID_OP from bad-format CopyTexSubImage in ANGLE for now. - r=daoshengmu

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8a706bd4d28b

Comment 10

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8820096 [details]
Bug 1305864 - Catch INVALID_OP from bad-format CopyTexSubImage in ANGLE for now. -

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8820096 [details]
Bug 1305864 - Catch INVALID_OP from bad-format CopyTexSubImage in ANGLE for now. -

Fix WebGL2 related issue. Beta51+ & Aurora52+. Should be in 51 beta 10.

Comment 12

[Iris Hsiao [:ihsiao]]

Check-in: https://hg.mozilla.org/releases/mozilla-aurora/rev/882a3059bd47 - Jeff Gilbert - Bug 1305864 - Catch INVALID_OP from bad-format CopyTexSubImage in ANGLE for now. - r=daoshengmu. a=gchang

Comment 13

[Iris Hsiao [:ihsiao]]

Check-in: https://hg.mozilla.org/releases/mozilla-beta/rev/823e70d0e391