1305891 - [webvr] Support Oculus Touch orientation and position tracking in the Gamepad API

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1305891 - Part 1: Support Oculus Touch orientation and position tracking;

Review commit: https://reviewboard.mozilla.org/r/112000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112000/

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1305891 - Part 2: Accept GamepadHand as the parameter when VRControllerHost constructs;

Review commit: https://reviewboard.mozilla.org/r/112002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112002/

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1305891 - Part 3: Replace GetIndex() with the index from mOculusController;

Review commit: https://reviewboard.mozilla.org/r/112004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112004/

Comment 4

[Daosheng Mu[:daoshengmu]]

(In reply to Daosheng Mu[:daoshengmu] from comment #3)
> Created attachment 8836610 [details]
> Bug 1305891 - Part 3: Replace GetIndex() with the index from
> mOculusController;
> 
> Review commit: https://reviewboard.mozilla.org/r/112004/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/112004/

GetIndex() is the same to the index of the mOculusController array. I would like to simplify them by using i here.

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8836608 [details]
Bug 1305891 - Part 1: Support Oculus Touch orientation and position tracking;

https://reviewboard.mozilla.org/r/112000/#review113900

lgtm, thanks!

Comment 6

[:kip (Kearwood Gilbert)]

Comment on attachment 8836609 [details]
Bug 1305891 - Part 2: Accept GamepadHand as the parameter when VRControllerHost constructs;

https://reviewboard.mozilla.org/r/112002/#review113896

This looks cleaner, thanks!

Comment 7

[:kip (Kearwood Gilbert)]

Comment on attachment 8836610 [details]
Bug 1305891 - Part 3: Replace GetIndex() with the index from mOculusController;

https://reviewboard.mozilla.org/r/112004/#review113898

lgtm

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc7233cd8ecd
Part 1: Support Oculus Touch orientation and position tracking; r=kip
https://hg.mozilla.org/integration/autoland/rev/03ee2e3b17b0
Part 2: Accept GamepadHand as the parameter when VRControllerHost constructs; r=kip
https://hg.mozilla.org/integration/autoland/rev/0328975ff0b7
Part 3: Replace GetIndex() with the index from mOculusController; r=kip

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cc7233cd8ecd
https://hg.mozilla.org/mozilla-central/rev/03ee2e3b17b0
https://hg.mozilla.org/mozilla-central/rev/0328975ff0b7