Closed Bug 1305891 Opened 4 years ago Closed 3 years ago

[webvr] Support Oculus Touch orientation and position tracking in the Gamepad API

Categories

(Core :: Graphics, defect, P3)

x86_64
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: kip, Assigned: daoshengmu)

References

Details

(Keywords: feature, Whiteboard: [gfx-noted][webvr])

Attachments

(3 files)

No description provided.
Keywords: feature
OS: Unspecified → Windows
Hardware: Unspecified → x86_64
Whiteboard: [gfx-noted]
Priority: -- → P3
Whiteboard: [gfx-noted] → [gfx-noted][webvr]
Assignee: nobody → dmu
(In reply to Daosheng Mu[:daoshengmu] from comment #3)
> Created attachment 8836610 [details]
> Bug 1305891 - Part 3: Replace GetIndex() with the index from
> mOculusController;
> 
> Review commit: https://reviewboard.mozilla.org/r/112004/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/112004/

GetIndex() is the same to the index of the mOculusController array. I would like to simplify them by using i here.
Comment on attachment 8836608 [details]
Bug 1305891 - Part 1: Support Oculus Touch orientation and position tracking;

https://reviewboard.mozilla.org/r/112000/#review113900

lgtm, thanks!
Attachment #8836608 - Flags: review?(kgilbert) → review+
Comment on attachment 8836609 [details]
Bug 1305891 - Part 2: Accept GamepadHand as the parameter when VRControllerHost constructs;

https://reviewboard.mozilla.org/r/112002/#review113896

This looks cleaner, thanks!
Attachment #8836609 - Flags: review?(kgilbert) → review+
Comment on attachment 8836610 [details]
Bug 1305891 - Part 3: Replace GetIndex() with the index from mOculusController;

https://reviewboard.mozilla.org/r/112004/#review113898

lgtm
Attachment #8836610 - Flags: review?(kgilbert) → review+
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc7233cd8ecd
Part 1: Support Oculus Touch orientation and position tracking; r=kip
https://hg.mozilla.org/integration/autoland/rev/03ee2e3b17b0
Part 2: Accept GamepadHand as the parameter when VRControllerHost constructs; r=kip
https://hg.mozilla.org/integration/autoland/rev/0328975ff0b7
Part 3: Replace GetIndex() with the index from mOculusController; r=kip
You need to log in before you can comment on or make changes to this bug.