Closed
Bug 1305906
Opened 8 years ago
Closed 6 years ago
BT.709 handling in WMFVideoMFTManager
Categories
(Core :: Graphics, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
(Keywords: feature, Whiteboard: [gfx-noted])
Attachments
(1 file, 6 obsolete files)
6.69 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
Created based on Bug 1210357 Comment 18.
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Updated•8 years ago
|
Summary: BT.709 handling with DXVA surface → BT.709 handling in WMFVideoMFTManager
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8804604 [details] [diff] [review] patch - Add YUVColorSpace handling in WMFVideoMFTManager :mattwoodrow, is there a better way to get YUVColorSpace?
Attachment #8804604 -
Flags: feedback?(matt.woodrow)
Comment 3•8 years ago
|
||
Comment on attachment 8804604 [details] [diff] [review] patch - Add YUVColorSpace handling in WMFVideoMFTManager Review of attachment 8804604 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/platforms/wmf/WMFVideoMFTManager.cpp @@ +620,5 @@ > return event->mSupportsConfig; > } > > +YUVColorSpace > +WMFVideoMFTManager::GetYUVColorSpace() It might be worth computing this in ConfigureVideoFrameGeometry and then just caching the result rather than querying the OutputMediaType every frame.
Attachment #8804604 -
Flags: feedback?(matt.woodrow) → feedback+
Assignee | ||
Comment 5•7 years ago
|
||
Rebase and clean up.
Attachment #8804604 -
Attachment is obsolete: true
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Tuanese from comment #4) > Can you finish and land this bug? Yes, I am going to work for it.
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8926310 -
Attachment is obsolete: true
Assignee | ||
Comment 8•7 years ago
|
||
Attachment #8926311 -
Attachment is obsolete: true
Assignee | ||
Comment 9•7 years ago
|
||
Attachment #8926321 -
Attachment is obsolete: true
Assignee | ||
Comment 10•7 years ago
|
||
To manage a regression risk, it seems better to split graphics side change to a different bug.
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #10) > To manage a regression risk, it seems better to split graphics side change > to a different bug. Bug 1415763 is created for it.
Depends on: 1415763
Assignee | ||
Comment 12•7 years ago
|
||
Attachment #8926676 -
Attachment is obsolete: true
Assignee | ||
Comment 13•6 years ago
|
||
Attachment #8926680 -
Attachment is obsolete: true
Assignee | ||
Comment 14•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c374f7916953c475bf51f4156640e63198faf388
Assignee | ||
Updated•6 years ago
|
Attachment #8932000 -
Flags: review?(matt.woodrow)
Updated•6 years ago
|
Attachment #8932000 -
Flags: review?(matt.woodrow) → review+
Comment 15•6 years ago
|
||
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/628753437e1e Add YUVColorSpace handling in WMFVideoMFTManager r=mattwoodrow
Comment 16•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/628753437e1e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•