Closed Bug 1305906 Opened 8 years ago Closed 6 years ago

BT.709 handling in WMFVideoMFTManager

Categories

(Core :: Graphics, defect, P3)

49 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

(Keywords: feature, Whiteboard: [gfx-noted])

Attachments

(1 file, 6 obsolete files)

Created based on Bug 1210357 Comment 18.
Depends on: 1210357
Keywords: feature
Priority: -- → P3
Whiteboard: [gfx-noted]
Assignee: nobody → sotaro.ikeda.g
Summary: BT.709 handling with DXVA surface → BT.709 handling in WMFVideoMFTManager
Comment on attachment 8804604 [details] [diff] [review]
patch - Add YUVColorSpace handling in WMFVideoMFTManager

:mattwoodrow, is there a better way to get YUVColorSpace?
Attachment #8804604 - Flags: feedback?(matt.woodrow)
Comment on attachment 8804604 [details] [diff] [review]
patch - Add YUVColorSpace handling in WMFVideoMFTManager

Review of attachment 8804604 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/wmf/WMFVideoMFTManager.cpp
@@ +620,5 @@
>    return event->mSupportsConfig;
>  }
>  
> +YUVColorSpace
> +WMFVideoMFTManager::GetYUVColorSpace()

It might be worth computing this in ConfigureVideoFrameGeometry and then just caching the result rather than querying the OutputMediaType every frame.
Attachment #8804604 - Flags: feedback?(matt.woodrow) → feedback+
Can you finish and land this bug?
Flags: needinfo?(sotaro.ikeda.g)
Rebase and clean up.
Attachment #8804604 - Attachment is obsolete: true
Flags: needinfo?(sotaro.ikeda.g)
(In reply to Tuanese from comment #4)
> Can you finish and land this bug?

Yes, I am going to work for it.
Attachment #8926310 - Attachment is obsolete: true
Attachment #8926311 - Attachment is obsolete: true
Attachment #8926321 - Attachment is obsolete: true
To manage a regression risk, it seems better to split graphics side change to a different bug.
(In reply to Sotaro Ikeda [:sotaro] from comment #10)
> To manage a regression risk, it seems better to split graphics side change
> to a different bug.

Bug 1415763 is created for it.
Depends on: 1415763
Attachment #8926676 - Attachment is obsolete: true
Attachment #8932000 - Flags: review?(matt.woodrow)
Attachment #8932000 - Flags: review?(matt.woodrow) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/628753437e1e
Add YUVColorSpace handling in WMFVideoMFTManager r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/628753437e1e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: