Bug 1305908 (bmo-fast-keywords)

For keywords search, use a table join instead of the weird thing we do now

NEW
Assigned to

Status

()

2 years ago
2 years ago

People

(Reporter: dylan, Assigned: dylan)

Tracking

Production

Details

Attachments

(1 attachment)

It seems like we can be a lot faster at keyword searches. Let's give that a try.
(Assignee)

Comment 1

2 years ago
Created attachment 8795593 [details] [diff] [review]
1305908_1.patch

there's got to be a downside to this.

I also changed quicksearch so that if there's no commas in the bang syntax it does a substring rather than anywords.

if you do an exact search this code *flies*
Attachment #8795593 - Flags: review?(dkl)
Comment on attachment 8795593 [details] [diff] [review]
1305908_1.patch

Review of attachment 8795593 [details] [diff] [review]:
-----------------------------------------------------------------

Needs to handle the negative conditions such as nowords, nowordssubstr, noequals, etc.

See Bugzilla::Search::_multiselect_negative

dkl

::: Bugzilla/Search.pm
@@ +2649,5 @@
>  
> +sub _keywords_nonchanged {
> +    my ($self, $args) = @_;
> +    my ($chart_id, $joins, $fields, $operator, $value) =
> +        @$args{qw(chart_id joins fields operator value)};

my ($chart_id, $joins) = @$args{qw(chart_id joins)};
Attachment #8795593 - Flags: review?(dkl) → review-
(Assignee)

Updated

2 years ago
Alias: bmo-fast-keywords
(Assignee)

Updated

2 years ago
Blocks: 1279238
You need to log in before you can comment on or make changes to this bug.