1305910 - Use vendored robustcheckout

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Gregory Szorc [:gps]]

Currently, install-mercurial.sh installs robustcheckout.py from tooltool. Now that we have %include magic in Docker image building, we can use the vendored robustcheckout.py file so it is always in sync with the Docker images.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1305910 - Use vendored robustcheckout.py;

When we initially implemented support for robustcheckout, we didn't
have the magic "%include" syntax in Dockerfiles. So we used tooltool
to download robustcheckout.py to the image.

Now that we have nice things, we can use the vendored robustcheckout.py
file.

As part of this, I realized we're inconsistently using /tmp, /setup
and /build for files used during image building. That should probably
be cleaned up. I'd rather not bloat scope for this bug, however.

Review commit: https://reviewboard.mozilla.org/r/81596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81596/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8795594 [details]
Bug 1305910 - Use vendored robustcheckout.py;

https://reviewboard.mozilla.org/r/81596/#review80446

::: testing/docker/recipes/install-mercurial.sh:59
(Diff revision 1)
>  else
>      echo "Do not know how to install Mercurial on this OS"
>      exit 1
>  fi
>  
>  mkdir -p /usr/local/mercurial

This should already exist or we're in trouble, right?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/380b8036c046
Vendor latest version of robustcheckout; r=me

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8795594 [details]
Bug 1305910 - Use vendored robustcheckout.py;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/81596/diff/1-2/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8795594 [details]
Bug 1305910 - Use vendored robustcheckout.py;

https://reviewboard.mozilla.org/r/81596/#review80446

> This should already exist or we're in trouble, right?

Yeah, I'll remove it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85980619dd33
Use vendored robustcheckout.py; r=dustin

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/380b8036c046
https://hg.mozilla.org/mozilla-central/rev/85980619dd33