1305912 - source step busted at |configure|

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, defect)

Description

[Edmund Wong (:ewong)]

TOOLTOOL_DIR issue?  (just filing this bug.. will think on it later)

checking for a shell... /bin/sh
checking for host system type... x86_64-pc-linux-gnu
checking for target system type... x86_64-pc-linux-gnu
checking whether cross compiling... no
checking for pkg_config... not found
DEBUG: pkg_config: Trying /builds/slave/rel-c-rel-source/comm-release/mozilla/gtk3/usr/local/bin/pkg-config
ERROR: Cannot find pkg_config
*** Fix above errors and then restart with\
               "make -f client.mk build"
make: *** [configure] Error 1

Comment 1

[Edmund Wong (:ewong)]

oh yes. in light that I remembered somehow that I have some patch 
somewhere in some bug that removes the no_tooltool=1 from
the mozconfigs but have forgotten about which bug this belongs
to, I'm going to attach a patch here that removes the no_tooltool=1 
from the release mozconfigs.

This means..   build #2. yup.. build 2.

Comment 2

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] remove no_tooltool=1 [checked-in]

will do a post-land-review.. or if someone can review this post-haste..
whichever option is the quickest.

Comment 3

[Edmund Wong (:ewong)]

Comment on attachment 8795600 [details] [diff] [review]
[mozconfigs] remove no_tooltool=1 [checked-in]

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: none. just can't build in automation
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch: none

Basically we need this patch so that our release builders
can use the tooltool packages.  

Note: the l10n-mozconfig changes were fixed by an earlier patch
so transplanting this patch from c-r to others
will need some finesse.

Comment 4

[Ian Neal]

Comment on attachment 8795600 [details] [diff] [review]
[mozconfigs] remove no_tooltool=1 [checked-in]

r/a=me for all repos

Comment 5

[Edmund Wong (:ewong)]

https://hg.mozilla.org/releases/comm-release/rev/eb3d525a2f5cf80bae00d00147008548402aa7dc
Bug 1305912  - Remove no_tooltool=1 from release mozconfigs. r+a=IanN

Comment 6

[Edmund Wong (:ewong)]

Attachment: [mozconfig] disable compile env during source step

Comment 7

[Edmund Wong (:ewong)]

Attachment: [configs] use the source mozconfig for source step.

this depends on the "disable compile env during source step"'s mozconfig.

Comment 8

[Philip Chee]

Comment on attachment 8795616 [details] [diff] [review]
[mozconfig] disable compile env during source step

Looks OK
> +export MOZ_DEBUG_SYMBOLS=1
but you might want to add:
ac_add_options --enable-debug-symbols
even if this is a dummy file.

Comment 9

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] disable compile env for source step.

Comment 10

[Edmund Wong (:ewong)]

Comment on attachment 8795628 [details] [diff] [review]
[mozconfigs] disable compile env for source step.

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: source step in release process doesn't need the compile env, so it's better to disable it.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch: none

Comment 11

[Philip Chee]

Comment on attachment 8795628 [details] [diff] [review]
[mozconfigs] disable compile env for source step.

a=me for comm-beta comm-release and anything else.

Comment 12

[Edmund Wong (:ewong)]

https://hg.mozilla.org/releases/comm-release/rev/762fbf1fa7f3ec770326b73bddc1e6e5d1a415c4
Bug 1305912 - Disable compile environment for source step. r+a=RattyAway

Comment 13

[Edmund Wong (:ewong)]

https://hg.mozilla.org/build/buildbot-configs/rev/77fb9f87b9f175d3e8b845848b1df4720f510148
Bug 1305912 - Use the source mozconfig instead of the release mozconfig for the source step.

Comment 14

[Edmund Wong (:ewong)]

something within the source mozconfig is bugging the source step.

Comment 15

[Edmund Wong (:ewong)]

Attachment: [mozconfig] fix for source mozconfig. typo fix.

Comment 16

[Edmund Wong (:ewong)]

https://hg.mozilla.org/releases/comm-release/rev/ead2b3d573c63f5c2b8d68d10b1b0b0f825f981c
Bug 1305912 - Fix for source mozconfig. r+a=bustagefix

Comment 17

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] fix source mozconfig. typofix and remove ccache option.

Comment 18

[Edmund Wong (:ewong)]

https://hg.mozilla.org/releases/comm-release/rev/6ada690edc807346f32266afa56054c0e4af9ea5
Bug 1305912 - Fix source mozconfig. r+a=bugfix

Comment 19

[Edmund Wong (:ewong)]

https://hg.mozilla.org/releases/comm-release/rev/013bcbc4360b099e77e0b64ce364cfbc9356d8f8
Bug 1305912  - Remove no_tooltool=1 from release mozconfigs. r+a=IanN

https://hg.mozilla.org/releases/comm-release/rev/55fd7a3517f7836b600e6dec832fd9615894ae05
Bug 1305912 - Disable compile environment for source step. r+a=RattyAway

https://hg.mozilla.org/releases/comm-release/rev/34bd688d21a88f3c13cd8d493d9fd8e494bfae9b
Bug 1305912 - Fix source mozconfig. r+a=bugfix