1305945 - The 'Find' option is not working correctly while RDM is enabled

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Mihai Boldan, Desktop QA [:mboldan]]

[Affected versions]:
- 52.0a1 (2016-09-27) 

[Affected platforms]:
- Windows 10x64, Mac OS X 10.11.6, Ubuntu 16.04x86

[Steps to reproduce]:
1. Launch Firefox.
2. From about:config, enable the devtools.responsive.html.enabled pref.
3. Enable RDM.
4. Open the Find option (Ctrl/Cmd+F) and search for an available string from the opened webpage.

[Expected result]:
- The searched string is correctly found and highlighted. 

[Actual result]:
- The searched string is not found. The search is performed only outside the RDM tool. 

[Regression range]:
- This is not a regression.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1305945 - Support find in page with RDM.

Review commit: https://reviewboard.mozilla.org/r/86470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86470/

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8801845 [details]
Bug 1305945 - Support find in page with RDM.

https://reviewboard.mozilla.org/r/86470/#review85648

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f62a24bd53b5
Support find in page with RDM. r=ochameau

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f62a24bd53b5

Comment 5

[Sayed [:LiquidO2]]

I have reproduced this bug with Nightly 52.0a1 (2016-09-28) in Elementary OS 64bit.

This bug's fix is now verified in latest Nighly 52.0a1

Build ID 	20161020030211
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

[testday-20161021]

Comment 6

[Mihai Boldan, Desktop QA [:mboldan]]

I've also manage to test this issue on Firefox 52.0a1 (2016-10-23) and noticed 2 potential issues:
- if using Find option to search for an available string while RDM is enabled and disable RDM, the search string is wrongly positioned: see - https://i.imgur.com/sUL3PWv.png
- the search stings from the Find bar are deleted when RDM is enabled/disabled. Also the page is in search mode, even if the Find box is empty. (https://i.imgur.com/sUL3PWv.png)(not sure if this is a RDM related issue).
Ryan, what's your opinion about this?

The tests were performed under Windows 10x64, Mac OS X 10.11.6, Ubuntu 16.04 x64.

Comment 7

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 52.0a1 (2016-09-28) (64-bit) in Windows 7 , 64 Bit !

This bug's is now verified in Latest Nightly 52.0a1

Build ID    :  20161025030205
User Agent  :  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0

[bugday-20161026]

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Mihai Boldan, QA [:mboldan] from comment #6)
> I've also manage to test this issue on Firefox 52.0a1 (2016-10-23) and
> noticed 2 potential issues:
> - if using Find option to search for an available string while RDM is
> enabled and disable RDM, the search string is wrongly positioned: see -
> https://i.imgur.com/sUL3PWv.png

I can't seem to reproduce this part myself, at least on macOS 10.12.  The highlight appears to reposition to match the text.

If you can still trigger it, let's file a bug to discuss further.

> - the search stings from the Find bar are deleted when RDM is
> enabled/disabled. Also the page is in search mode, even if the Find box is
> empty. (https://i.imgur.com/sUL3PWv.png)(not sure if this is a RDM related
> issue).

Yes, I can reproduce this part.  Let's file a separate bug for this.

Thanks for testing!

Comment 9

[Mihai Boldan, Desktop QA [:mboldan]]

See the comments inline.

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #8)
> (In reply to Mihai Boldan, QA [:mboldan] from comment #6)
> > I've also manage to test this issue on Firefox 52.0a1 (2016-10-23) and
> > noticed 2 potential issues:
> > - if using Find option to search for an available string while RDM is
> > enabled and disable RDM, the search string is wrongly positioned: see -
> > https://i.imgur.com/sUL3PWv.png
> 
> I can't seem to reproduce this part myself, at least on macOS 10.12.  The
> highlight appears to reposition to match the text.

The issue is still reproducible on my side, but I'm not quite sure that this is an RDM issue, since I noticed a couple issues related to the Find option, without enabling RDM. 
I will investigate and search for a regression asap.

> 
> If you can still trigger it, let's file a bug to discuss further.
> 
> > - the search stings from the Find bar are deleted when RDM is
> > enabled/disabled. Also the page is in search mode, even if the Find box is
> > empty. (https://i.imgur.com/sUL3PWv.png)(not sure if this is a RDM related
> > issue).
> 
> Yes, I can reproduce this part.  Let's file a separate bug for this.

I've logged Bug 1313337 for this issue.

> 
> Thanks for testing!

I am marking this issue Verified Fixed since one of the found issues was logged separately and the other one is unlikely to be related to this tool.