1305948 - Fix typed array template object OOM bug

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

This caused test failures in another bug.

Comment 1

[Sander Mathijs van Veen]

Comment on attachment 8795643 [details] [diff] [review]
Patch

Review of attachment 8795643 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/108c16a295e7
Fix OOM bug in TypedArrayObject::GetTemplateObjectForNative. r=smvv

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/108c16a295e7

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 8795643 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1248163.
[User impact if declined]: Issues on OOM.
[Describe test coverage new/current, TreeHerder]: Fixes the test and we have test coverage for this code.
[Risks and why]: Low risk.
[String/UUID change made/needed]: None.

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8795643 [details] [diff] [review]
Patch

Fixes OOM issues, Aurora51+, Beta50+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a9ba2aa61f5b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f599f4e3d84f