Closed Bug 1305948 Opened 8 years ago Closed 8 years ago

Fix typed array template object OOM bug

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Patch
2.24 KB, patch
sandervv
: review+
ritu
: approval-mozilla-aurora+
ritu
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
This caused test failures in another bug.
Attachment #8795643 - Flags: review?(sandervv)
Comment on attachment 8795643 [details] [diff] [review]
Patch

Review of attachment 8795643 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8795643 - Flags: review?(sandervv) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/108c16a295e7
Fix OOM bug in TypedArrayObject::GetTemplateObjectForNative. r=smvv
https://hg.mozilla.org/mozilla-central/rev/108c16a295e7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment on attachment 8795643 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1248163.
[User impact if declined]: Issues on OOM.
[Describe test coverage new/current, TreeHerder]: Fixes the test and we have test coverage for this code.
[Risks and why]: Low risk.
[String/UUID change made/needed]: None.
Attachment #8795643 - Flags: approval-mozilla-beta?
Attachment #8795643 - Flags: approval-mozilla-aurora?
Comment on attachment 8795643 [details] [diff] [review]
Patch

Fixes OOM issues, Aurora51+, Beta50+
Attachment #8795643 - Flags: approval-mozilla-beta?
Attachment #8795643 - Flags: approval-mozilla-beta+
Attachment #8795643 - Flags: approval-mozilla-aurora?
Attachment #8795643 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: