Fix typed array template object OOM bug

RESOLVED FIXED in Firefox 50

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed, firefox51 fixed, firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Created attachment 8795643 [details] [diff] [review]
Patch

This caused test failures in another bug.
Attachment #8795643 - Flags: review?(sandervv)
Comment on attachment 8795643 [details] [diff] [review]
Patch

Review of attachment 8795643 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8795643 - Flags: review?(sandervv) → review+

Comment 2

a year ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/108c16a295e7
Fix OOM bug in TypedArrayObject::GetTemplateObjectForNative. r=smvv

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/108c16a295e7
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
(Assignee)

Comment 4

a year ago
Comment on attachment 8795643 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1248163.
[User impact if declined]: Issues on OOM.
[Describe test coverage new/current, TreeHerder]: Fixes the test and we have test coverage for this code.
[Risks and why]: Low risk.
[String/UUID change made/needed]: None.
Attachment #8795643 - Flags: approval-mozilla-beta?
Attachment #8795643 - Flags: approval-mozilla-aurora?
status-firefox50: --- → affected
status-firefox51: --- → affected
Comment on attachment 8795643 [details] [diff] [review]
Patch

Fixes OOM issues, Aurora51+, Beta50+
Attachment #8795643 - Flags: approval-mozilla-beta?
Attachment #8795643 - Flags: approval-mozilla-beta+
Attachment #8795643 - Flags: approval-mozilla-aurora?
Attachment #8795643 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/a9ba2aa61f5b
status-firefox51: affected → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/f599f4e3d84f
status-firefox50: affected → fixed
You need to log in before you can comment on or make changes to this bug.