Closed Bug 1305967 Opened 3 years ago Closed 3 years ago

Fix Telemetry for TLS 0RTT

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: dragana, Assigned: dragana)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 1 obsolete file)

Fix comments from bug 1296288 comment 11.
Assignee: nobody → dd.mozilla
Blocks: 1296288
Status: NEW → ASSIGNED
(In reply to François Marier [:francois] from comment #11)
> Comment on attachment 8790631 [details] [diff] [review]
> bug_1296288.patch
> 
> Review of attachment 8790631 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> These telemetry probes appear to be exploratory and our usual guidelines for
> this is to make it expire in 6 releases (58).
> 
I have changed this.

> If it's still useful and being looked at, it's no problem to extend it
> before it expires.
> 
> ::: toolkit/components/telemetry/Histograms.json
> @@ +1719,5 @@
> > +  "TLS_EARLY_DATA_NEGOTIATED": {
> > +    "expires_in_version": "never",
> > +    "kind": "enumerated",
> > +    "n_values": 3,
> > +    "description": "TLS early data was available: 0 - not available, 1 - avaialable but not used, 2 - available and used.",
> 
> nit: typo ("avaialable")
> 
> Also, by "available", do you mean that it's being advertised by the server
> or is that a client-side thing?
> 

I have change this to "possible" because it should mean: client advertised, server accepted, alpn was advertise as well and on the new connection we have these key still cached.
Attached patch bug_1305967.patch (obsolete) — Splinter Review
Attachment #8795689 - Flags: review?(francois)
Whiteboard: [necko-active]
Comment on attachment 8795689 [details] [diff] [review]
bug_1305967.patch

Review of attachment 8795689 [details] [diff] [review]:
-----------------------------------------------------------------

Small typo to fix, but otherwise datareview+.

::: toolkit/components/telemetry/Histograms.json
@@ +1726,3 @@
>      "kind": "enumerated",
>      "n_values": 3,
> +    "description": "Sending TLS early data was possible: 0 - not not possible, 1 - possible but not used, 2 - possible and used.",

typo: "not not" -> "not"
Attachment #8795689 - Flags: review?(francois) → review+
Attachment #8795689 - Attachment is obsolete: true
Attachment #8796102 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/66a5416f87a2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.