1305984 - First-run for restricted profiles is displayed on Guest Mode

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Family Friendly Browsing, defect, P1)

Description

[Sorina Florean [:sflorean]]

Attachment: Screenshot_2016-09-28-15-57-47.png

Environment: 
Device: Prestigio Grace X5 (Android 4.4.2);
Build: Nightly 52.0a1 (2016-09-27);

Steps to reproduce:
1. Launch Fennec and go to Menu -> Tools -> New Guest Session; 

Expected result:
Guest browsing is enabled with focus on Top Sites.

Actual result:
First-run for restricted profiles is displayed.
Please check the attachment.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

I can see this on a Nexus 6P too.

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/firstrun/FirstrunPager.java

This line:
> if (Restrictions.isUserRestricted(context)) {

should probably be:
> if (Restrictions.isRestrictedProfile(context)) {

Guest profiles are restricted too but we only want to show this for restricted (Android) profiles (= Family friendly browsing).

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1305984 - Only show "family friendly browsing" first run for restricted profiles.

Review commit: https://reviewboard.mozilla.org/r/83912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83912/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8798394 [details]
Bug 1305984 - Only show "family friendly browsing" first run for restricted profiles.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/83912/diff/1-2/

Comment 4

[:Grisha Kruglov]

Comment on attachment 8798394 [details]
Bug 1305984 - Only show "family friendly browsing" first run for restricted profiles.

https://reviewboard.mozilla.org/r/83912/#review83534

LGTM If it works for you. I'm not very familiar with this stuff.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09f5cb57521f
Only show "family friendly browsing" first run for restricted profiles. r=Grisha

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/09f5cb57521f

Comment 7

[Sorina Florean [:sflorean]]

Verified as fixed in build 52.0a1 (2016-10-14);
Device: LG G4 (Android 5.1).
First-run for restricted profiles is not displayed on Guest Mode.

Comment 8

[Ioana Chiorean]

Are we gonna push this in upper versions or will ride the train and it is wontfix for 51?

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

We uplifted the patch in bug 1323408 - The patch fixes this issue too. So we won't need to uplift this one.

Comment 10

[Ioana Chiorean]

Thanks Sebastian.