First-run for restricted profiles is displayed on Guest Mode

RESOLVED FIXED in Firefox 51

Status

()

Firefox for Android
Family Friendly Browsing
P1
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: sorina, Assigned: sebastian)

Tracking

(Blocks: 1 bug)

52 Branch
Firefox 52
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 unaffected, fennec+, firefox50 unaffected, firefox51 fixed, firefox52 verified)

Details

(Whiteboard: [MobileAS])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Created attachment 8795698 [details]
Screenshot_2016-09-28-15-57-47.png

Environment: 
Device: Prestigio Grace X5 (Android 4.4.2);
Build: Nightly 52.0a1 (2016-09-27);

Steps to reproduce:
1. Launch Fennec and go to Menu -> Tools -> New Guest Session; 

Expected result:
Guest browsing is enabled with focus on Top Sites.

Actual result:
First-run for restricted profiles is displayed.
Please check the attachment.
(Assignee)

Comment 1

a year ago
I can see this on a Nexus 6P too.

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/firstrun/FirstrunPager.java

This line:
> if (Restrictions.isUserRestricted(context)) {

should probably be:
> if (Restrictions.isRestrictedProfile(context)) {

Guest profiles are restricted too but we only want to show this for restricted (Android) profiles (= Family friendly browsing).
tracking-fennec: --- → ?
status-firefox49: --- → ?
status-firefox50: --- → ?
status-firefox51: --- → ?
(Assignee)

Updated

a year ago
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
tracking-fennec: ? → +
(Assignee)

Updated

a year ago
status-firefox49: ? → unaffected
status-firefox50: ? → unaffected
status-firefox51: ? → affected
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8798394 [details]
Bug 1305984 - Only show "family friendly browsing" first run for restricted profiles.

https://reviewboard.mozilla.org/r/83912/#review83534

LGTM If it works for you. I'm not very familiar with this stuff.
Attachment #8798394 - Flags: review?(gkruglov) → review+

Comment 5

a year ago
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/09f5cb57521f
Only show "family friendly browsing" first run for restricted profiles. r=Grisha
(Assignee)

Updated

a year ago
Priority: -- → P1
Whiteboard: [MobileAS]

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/09f5cb57521f
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
(Reporter)

Comment 7

a year ago
Verified as fixed in build 52.0a1 (2016-10-14);
Device: LG G4 (Android 5.1).
First-run for restricted profiles is not displayed on Guest Mode.
status-firefox52: fixed → verified
Iteration: --- → 1.6
Depends on: 1323408

Comment 8

10 months ago
Are we gonna push this in upper versions or will ride the train and it is wontfix for 51?
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 9

10 months ago
We uplifted the patch in bug 1323408 - The patch fixes this issue too. So we won't need to uplift this one.
Flags: needinfo?(s.kaspari)

Comment 10

10 months ago
Thanks Sebastian.
status-firefox51: affected → fixed
You need to log in before you can comment on or make changes to this bug.